mapnik-reference icon indicating copy to clipboard operation
mapnik-reference copied to clipboard

Restore pull requests

Open springmeyer opened this issue 8 years ago • 4 comments

A few outstanding pull requests were automatically closed (and cannot be re-opened) now that I've deleted the master branch and we use gh-pages as default (https://github.com/mapnik/mapnik-reference/pull/107#issuecomment-139035521). This ticket is to track those pulls for revisiting when there is time:

  • [x] https://github.com/mapnik/mapnik-reference/pull/114
  • [x] https://github.com/mapnik/mapnik-reference/pull/109
  • [ ] https://github.com/mapnik/mapnik-reference/pull/62 (if carto pull is ever accepted)
  • [ ] https://github.com/mapnik/mapnik-reference/pull/61 (if carto pull is ever accepted)

springmeyer avatar Mar 05 '16 21:03 springmeyer

I plan to work on #61 and #62 again as time permits, because I think that they are important additions. However, accepting the changes into this repository would be a prerequisite for accepting them into carto.

nebulon42 avatar Mar 07 '16 20:03 nebulon42

@nebulon42 - that is great you are interested in working on the group-symbolizer support. Also, with further thought I agree that it likely makes sense to land in mapnik-reference first. I'm open to this as long as we mark all the properties as experimental.

springmeyer avatar Mar 10 '16 18:03 springmeyer

@springmeyer - given the fact that corresponding carto pull requests for #62 and #61 can never land and according to importance of mapnik-reference for non-carto users, what about to merge these pull requests with some "area of validity" introduced to exclude it from carto? Something similar to https://github.com/mapnik/mapnik-reference/issues/101.

talaj avatar Nov 01 '16 11:11 talaj

👍 @talaj - Agree that anything in Mapnik should be visible in mapnik-reference irregardless of its binding in carto

springmeyer avatar Nov 02 '16 04:11 springmeyer