mapme.biodiversity icon indicating copy to clipboard operation
mapme.biodiversity copied to clipboard

Add kba

Open karpfen opened this issue 1 year ago • 4 comments

karpfen avatar Aug 22 '24 09:08 karpfen

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.70%. Comparing base (8f27b5b) to head (1984aed). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   86.21%   86.70%   +0.49%     
==========================================
  Files          60       62       +2     
  Lines        2691     2723      +32     
==========================================
+ Hits         2320     2361      +41     
+ Misses        371      362       -9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 22 '24 09:08 codecov[bot]

@goergen95 thanks for the comments, will adapt! I also just noticed that I'm using native pipes in the unit test. I'll replace them so we're compatible with R 3.5.0

karpfen avatar Aug 22 '24 09:08 karpfen

Yes, please do. Also, please try to pipes sparingly. We still have #98 open.

goergen95 avatar Aug 22 '24 09:08 goergen95

There are also failures related to ipbes and carbon which I'll try to figure out

goergen95 avatar Aug 22 '24 10:08 goergen95

@goergen95 do you know how I can "force merge" this PR despite the failing check? The merge button is greyed out for me.

karpfen avatar Aug 22 '24 12:08 karpfen

Guess it requires admin privileges. Shall I (I would squash the commits to a single one)?

goergen95 avatar Aug 22 '24 12:08 goergen95

Yes, please!

karpfen avatar Aug 22 '24 12:08 karpfen