Remove all `.unwrap()` and `.expect()`

[maxammann]

🤔 Expected Behavior

Return a Result for failable operations.

😯 Current Behavior

We use sometimes unwrap or expecte because of lazyness.

💁 Possible Solution

🔦 Context

💻 Examples

[iakev]

Hello, I would love to work on the issue since it is a good Rust first issue. Any specificities I should know?

[maxammann]

Hello @iakev I'm merging in a rather large PR in the next 1h :) So its better to start working after that. Apart from that you should be fine.

Maybe it could make sense to leave some .expect() if they are very unlikely, or if you are unlikely to hit them after setting up the map.

[maxammann]

Or probably tomorrow..

[iakev]

Okay, no problem will start working on it tomorrow. In case I find any difficulties, I presume I can contact you right?

On Mon, May 9, 2022 at 6:59 PM Max Ammann @.***> wrote:

Or probably tomorrow..

— Reply to this email directly, view it on GitHub https://github.com/maplibre/maplibre-rs/issues/92#issuecomment-1121284859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD64W4NF5MOGTIPJ5NN5WSLVJEY4ZANCNFSM5VOCYBBA . You are receiving this because you were mentioned.Message ID: @.***>

[maxammann]

Yes, absolutely. You can also reach me on matrix.org Its @maxammann

[iakev]

Hello, I hope you are fine. So I have tweaked one file just wanted to hear if what am doing is correct so that I can continue. Can I push the branch for your review?

Best Regards, Kevin Mwongera

On Mon, May 9, 2022 at 10:52 PM Max Ammann @.***> wrote:

Yes, absolutely. You can also reach me on matrix.org Its @maxammann https://github.com/maxammann

— Reply to this email directly, view it on GitHub https://github.com/maplibre/maplibre-rs/issues/92#issuecomment-1121512019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD64W4IRXY6ACNPCATAHGDDVJFUHJANCNFSM5VOCYBBA . You are receiving this because you were mentioned.Message ID: @.***>

[maxammann]

Sure, just push the branch to your fork and then open a PR in "Draft Mode": https://github.blog/2019-02-14-introducing-draft-pull-requests/

[iakev]

Thanks, I will do that. Kindly let me know your thoughts.

On Thu, May 12, 2022 at 11:45 AM Max Ammann @.***> wrote:

Sure, just push the branch to your fork and then open a PR in "Draft Mode": https://github.blog/2019-02-14-introducing-draft-pull-requests/

— Reply to this email directly, view it on GitHub https://github.com/maplibre/maplibre-rs/issues/92#issuecomment-1124701695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD64W4I54GW3C6AB56LDZQTVJTAKXANCNFSM5VOCYBBA . You are receiving this because you were mentioned.Message ID: @.***>

[xinslu]

Hi, Is this issue still open? If yes, then I'd love to get involved!

[maxammann]

Hi! The description and goal of this issue needs some refinement. Ill try to refine it this weekend!