maplibre-react-native icon indicating copy to clipboard operation
maplibre-react-native copied to clipboard

fix: make MarkerView props with defaults optional

Open KiwiKilian opened this issue 1 year ago • 2 comments
trafficstars

Description

MarkerViewProps are currently wrongly typed. There are props with defaults but the types are required. It's also a mismatch with the docs.

Checklist

  • [ ] I have tested this on a device/simulator for each compatible OS
  • [x] I formatted JS and TS files with running yarn lint:fix in the root folder
  • [x] I have run tests via yarn test in the root folder
  • [x] I updated the documentation with running yarn generate in the root folder
  • [x] I mentioned this change in CHANGELOG.md
  • [ ] I updated the typings files (index.d.ts)
  • [ ] I added/updated a sample (/example)

KiwiKilian avatar Sep 30 '24 07:09 KiwiKilian

Sorry, @KiwiKilian, can you pull main and rebase. I really wish we could avoid branch conflicts with the changelog.

tyrauber avatar Oct 03 '24 15:10 tyrauber

Rebased. Switching to semantic-release or changesets would help with those changelog problems. The formatting is also all over the place 😅.

KiwiKilian avatar Oct 04 '24 15:10 KiwiKilian

:tada: This PR is included in version 10.0.0-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Dec 02 '24 11:12 github-actions[bot]