maplibre-react-native
maplibre-react-native copied to clipboard
fix: round compass margins and attribution position to nearest integers [android]
Description
Fixes compass margins and attribution positions.
At the moment, we are casting density (float) to integer which is loosing decimal part. In same cases it leads to big differences. For example, Xiomi Redmi 12 has density 2.75.
Instead we should round to the nearest integer.
Checklist
- [x] I have tested this on a device/simulator for each compatible OS
- [ ] I formatted JS and TS files with running
yarn lint:fixin the root folder - [ ] I have run tests via
yarn testin the root folder - [ ] I updated the documentation with running
yarn generatein the root folder - [ ] I mentioned this change in
CHANGELOG.md - [ ] I updated the typings files (
index.d.ts) - [ ] I added/updated a sample (
/example)
Screenshot OR Video
Hey @caspg, can you resolve these conflicts and I'll merge it in? Sorry for the delay.
@tyrauber done
:tada: This PR is included in version 10.0.0-beta.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket: