maplibre-react-native icon indicating copy to clipboard operation
maplibre-react-native copied to clipboard

fix: round compass margins and attribution position to nearest integers [android]

Open caspg opened this issue 1 year ago • 2 comments

Description

Fixes compass margins and attribution positions.

At the moment, we are casting density (float) to integer which is loosing decimal part. In same cases it leads to big differences. For example, Xiomi Redmi 12 has density 2.75.

Instead we should round to the nearest integer.

Checklist

  • [x] I have tested this on a device/simulator for each compatible OS
  • [ ] I formatted JS and TS files with running yarn lint:fix in the root folder
  • [ ] I have run tests via yarn test in the root folder
  • [ ] I updated the documentation with running yarn generate in the root folder
  • [ ] I mentioned this change in CHANGELOG.md
  • [ ] I updated the typings files (index.d.ts)
  • [ ] I added/updated a sample (/example)

Screenshot OR Video

Screenshot_2024-03-17-21-45-29-137_com caspg velomapa

caspg avatar Mar 17 '24 20:03 caspg

Hey @caspg, can you resolve these conflicts and I'll merge it in? Sorry for the delay.

tyrauber avatar May 13 '24 14:05 tyrauber

@tyrauber done

caspg avatar May 14 '24 13:05 caspg

:tada: This PR is included in version 10.0.0-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Dec 02 '24 11:12 github-actions[bot]