maplibre-react-native icon indicating copy to clipboard operation
maplibre-react-native copied to clipboard

Figure out Detox and why it's so slow

Open ianthetechie opened this issue 2 years ago • 3 comments

Local iOS builds are super fast, but the Detox build is super slow and the tests sometimes fail. Tangentially related to #22, we need to understand what's going on here as this was inherited from upstream. Going through their guides (https://wix.github.io/Detox/docs/introduction/project-setup/), I don't see a .detoxrc.js, so I'm not sure if we're even using it correctly, nor what the tests actually do at the moment.

Also curiously, it claims to be a cross-platform framework, but it's only integrated into the iOS CI actions. If this is providing a real benefit, we should probably get it running on Android as well.

ianthetechie avatar Dec 30 '22 06:12 ianthetechie

:thinking: @ianthetechie, this appears to be a question rather than an issue
please use GitHub Discussions or Slack.

github-actions[bot] avatar Dec 30 '22 06:12 github-actions[bot]

Oops :D Forgot that action existed....

ianthetechie avatar Dec 30 '22 06:12 ianthetechie

The tests currently only start the example app and check whether components are rendered in the root page. So basically they don't test the actual maplibre functionality atm. What does make sense though that it is building the app (at least for ios) in the CI. Starting detox v20 the config became a little bit simpler. Check out this PR to see what changed.

sarahsporck avatar Jan 24 '24 12:01 sarahsporck

Fixed by #535

KiwiKilian avatar Dec 08 '24 10:12 KiwiKilian

:tada: This issue has been resolved in version 10.0.0-beta.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Dec 08 '24 10:12 github-actions[bot]