maplibre-react-native icon indicating copy to clipboard operation
maplibre-react-native copied to clipboard

feat: pnpm

Open tyrauber opened this issue 2 years ago • 2 comments
trafficstars

Remove yarn / pnp, in favor of pnpm.

✅ $ pnpm unittest ✅ $ pnpm test:plugin ✅ $ pnpm build:plugin ✅ $ pnpm generate 🚩 $ pnpm lint

Checklist

  • [ ] I have tested this on a device/simulator for each compatible OS
  • [ ] I formatted JS and TS files with running yarn lint:fix in the root folder
  • [X] I have run tests via yarn test in the root folder
  • [X] I updated the documentation with running yarn generate in the root folder
  • [ ] I mentioned this change in CHANGELOG.md
  • [ ] I updated the typings files (index.d.ts)
  • [ ] I added/updated a sample (/example)

tyrauber avatar Nov 12 '23 23:11 tyrauber

What would be tha advantage of pnpm in this repo? Could you work out some more context?

sarahsporck avatar Jan 24 '24 09:01 sarahsporck

Hi @sarahsporck, the primary motivation was to reduce the amount of build complexity with the current setup of yarn and pnp. I believe, and please correct me if I am wrong, but this PR eliminates a whole lot of unnecessary code and configuration - 45,000 lines. Please confirm. Tests run, lint works and the plugin and library build.

There are additional benefits of PNPM over yarn and npm. It works well out of the box with monorepos and is really good at managing dependency disk space. I might be able to get both yarn and pnpm working in the same repo, if you think that is beneficial.

Take a look at #162 that builds upon this PR to implement Expo in a Monorepo environment.

tyrauber avatar Jan 24 '24 14:01 tyrauber