maplibre-native
maplibre-native copied to clipboard
maplibre
Increase minimum node version to 14
We recently released @maplibre/maplibre-gl-native to npm, with node 10 support (thanks @acalcutt !).
PR here: https://github.com/maplibre/maplibre-gl-native/pull/378
This can be used as a compatibility version for migration (v5.0.1), but as node 10 passed the end of life a while ago, this PR deprecates it again, raising the minimum supported node version to 14.
I think it's a good idea to drop Node 10. I wanted it included to serve as an upgrade path, but like you said we can recommend v5.0.1 for that. When we do make a non-prerelease we should make it a major version bump, so like you said we can point to v5 as compatibility and v6+ going forward.
Yeah, I think this should be a major version bump (that way v5 can still receive critical patches, if necessary, without requiring users to upgrade node). Otherwise - great idea, v10 should be mostly deprecated anyway by now.
@acalcutt , would it take a deprecation of node-14 as well to get the arm runners going? and would it in that case be possible with this setup to make a universal build compatible with non-arm?
FWIW I think I was able to setup an arm build going w/ node v14 - I'll try to publish a branch for that (or maybe it works already, gotta check). I do know that node v14 does run on arm64, if you really try (as in - compile it on macos)
@jutaz awesome! We got 3 dedicated m1 build runners waiting idle, while these small github intel-mac runners take all the load, and I noticed arm support has been requested. I read somewhere that arm support was only introduced in 16, but maybe there is a trick to backport support.