maplibre-native icon indicating copy to clipboard operation
maplibre-native copied to clipboard

Update MapLibre GL JS to d8cf29023392b7de85b365cdc17e50ae263a357c

Open github-actions[bot] opened this issue 2 years ago • 4 comments

github-actions[bot] avatar Jul 05 '22 19:07 github-actions[bot]

This one introduces some failing tests...

➜  maplibre-gl-native git:(update-gl-js-to-d8cf29023392b7de85b365cdc17e50ae263a357c) ✗ cat render-test.log | grep "* failed"
* failed render-tests/runtime-styling/image-update-pattern
* failed render-tests/runtime-styling/image-add-pattern
* failed render-tests/regressions/mapbox-gl-js#5978
* failed render-tests/regressions/mapbox-gl-js#3107
* failed render-tests/regressions/mapbox-gl-native#9976
* failed render-tests/regressions/mapbox-gl-js#8273
* failed render-tests/regressions/mapbox-gl-js#2533
* failed render-tests/icon-text-fit/enlargen-both
* failed render-tests/line-pattern/pitch
* failed render-tests/line-pattern/step-curve
* failed render-tests/line-pattern/zoom-expression
* failed render-tests/line-pattern/property-function
* failed render-tests/line-pattern/literal
* failed render-tests/line-pattern/overscaled
* failed render-tests/line-pattern/@2x
* failed render-tests/fill-opacity/property-function-pattern
* failed render-tests/fill-pattern/case-data-expression
* failed render-tests/fill-pattern/wrapping-with-interpolation
* failed render-tests/fill-pattern/uneven-pattern
* failed render-tests/fill-pattern/@2x

wipfli avatar Jul 05 '22 19:07 wipfli

It will be hard to rebase those MRs. They may also contain less changes. I would wait that the first one is merged before opening more.

ntadej avatar Jul 05 '22 19:07 ntadej

This is the associated commit in GL JS: https://github.com/maplibre/maplibre-gl-js/commit/d8cf29023392b7de85b365cdc17e50ae263a357c

wipfli avatar Jul 05 '22 19:07 wipfli

I won't open more for now. This one is problematic already.

wipfli avatar Jul 05 '22 19:07 wipfli

I guess this PR can be closed and branch deleted?

ntadej avatar Apr 11 '23 12:04 ntadej

Yes, thanks @ntadej

wipfli avatar Apr 12 '23 10:04 wipfli