maplibre-native icon indicating copy to clipboard operation
maplibre-native copied to clipboard

Update MapLibre GL JS to eeefc070d7333b21b205be3882df9b2e3cd444d1

Open github-actions[bot] opened this issue 2 years ago • 15 comments

github-actions[bot] avatar Jul 05 '22 19:07 github-actions[bot]

The only render test that fails here is render-tests/icon-text-fit/enlargen-both, which already fails on main. So far so good...

wipfli avatar Jul 05 '22 19:07 wipfli

Can we get the tests in the CI first :)

ntadej avatar Jul 05 '22 19:07 ntadej

#357 aims to do that, yes

wipfli avatar Jul 05 '22 19:07 wipfli

Also let's maybe tag a release before that.

ntadej avatar Jul 09 '22 09:07 ntadej

We should be able to merge this once we have render tests in CI #357

wipfli avatar Jul 18 '22 15:07 wipfli

Converting to draft until then...

wipfli avatar Jul 18 '22 15:07 wipfli

@wipfli The render tests are merged, so can this be converted back from draft now?

birkskyum avatar Aug 29 '22 12:08 birkskyum

I think the render tests should fail on this one so maybe it is better to keep it as a draft. But lets see...

wipfli avatar Aug 29 '22 12:08 wipfli

What workflow does the render test run in?

birkskyum avatar Aug 29 '22 13:08 birkskyum

I think it is node

wipfli avatar Aug 29 '22 13:08 wipfli

https://github.com/maplibre/maplibre-gl-native/blob/ad91ff235d2a25e86ed3e94b2ce7593fdc10ed8b/.github/workflows/node-ci.yml#L166-L175

wipfli avatar Aug 29 '22 13:08 wipfli

Great, so that looks like a success so far

birkskyum avatar Aug 29 '22 13:08 birkskyum

I think we should still tag core before we start updating JS.

ntadej avatar Aug 29 '22 13:08 ntadej

@ntadej , I'm all for it if you think it will improve maintainability, but what does it look like exactly? It was a bit tedious to update the maplibre-native-base upstream of the core, and with this, would we then have a 3-repo long chain if it becomes it's own submodule sitting between the base and the sdk's? Could the core maybe merge with the base in this refactoring? (is there a discussion thread about this anywhere?)

birkskyum avatar Aug 29 '22 15:08 birkskyum

The discussion is kind of here: https://github.com/maplibre/maplibre-gl-native/discussions/371

The issue I see is that we are nearing a relatively stable native "core". It may be good to make a snapshot so people can stay with this version for a while. Maybe it would even be a motivation to release all SDKs so tagging also @roblabs for his opinion.

ntadej avatar Aug 29 '22 16:08 ntadej

I guess this PR can be closed and branch deleted?

ntadej avatar Apr 11 '23 12:04 ntadej

yes, without maplibre-gl-js in Native, it makes little sense to keep.

birkskyum avatar Apr 11 '23 12:04 birkskyum