maplibre-native-qt icon indicating copy to clipboard operation
maplibre-native-qt copied to clipboard

Update to the latest version of MapLibre Core

Open ntadej opened this issue 2 years ago • 10 comments

Update to the latest version of MapLibre Core. This PR will probably also contain the Metal integration.

Closes #181

ntadej avatar Oct 31 '23 10:10 ntadej

What's holding this PR in draft stage?

birkskyum avatar Jan 26 '24 22:01 birkskyum

We need stable Metal support so I do not plan this to be merged for version 3.0, but more for 3.1 or one of the later ones.

ntadej avatar Jan 26 '24 22:01 ntadej

@louwers , does the start of the Vulkan implementation indicate that the Metal backend is considered stable now?

birkskyum avatar Jul 01 '24 20:07 birkskyum

First the 3.0 release will be tagged with the OpenGL 2 backend. Then we can start thinking about Metal integration.

ntadej avatar Jul 27 '24 14:07 ntadej

The Metal backend has been considered stable since the MapLibre Native for iOS 6.0.0 release which includes the Metal renderer.

louwers avatar Jul 27 '24 15:07 louwers

@ntadej , if the 3.0 doesn't have this PR, and this PR is breaking (opengl2 sunset), wouldn't it be necessary to bump to 4.0 rather than 3.1?

birkskyum avatar Jul 29 '24 12:07 birkskyum

That's an interesting question. I think as long as no devices stop working, switching from OpenGL to Metal is not necessarily a breaking change.

My idea was anyways to find a way to allow to toggle between two backends for a while.

ntadej avatar Jul 29 '24 12:07 ntadej

@ntadej , my concern is not related to Metal. There are ~4.1% of active android phones that doesn't support opengl3/4 yet, so upgrading from opengl2 to opengl3/4 which this PR does could warrant a major release, since this might be breaking on those phones. I don't know the support distribution of opengl for windows / linux desktop users, but i expect there will be some tail as well, albeit maybe small.

birkskyum avatar Aug 04 '24 18:08 birkskyum