maplibre-gl-js icon indicating copy to clipboard operation
maplibre-gl-js copied to clipboard

fix: order of normalizeSpriteURL and transformRequest in load sprites

Open Kai-W opened this issue 11 months ago • 1 comments

This PR fixes the order of transformRequest and normalizeSpriteURL on loading Sprites.

(#3897)

Launch Checklist

  • [x] Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • [x] Briefly describe the changes in this PR.
  • [x] Link to related issues.
  • [ ] Include before/after visuals or gifs if this PR includes visual changes.
  • [x] Write tests for all new functionality.
  • [ ] Document any changes to public APIs.
  • [ ] Post benchmark scores.
  • [x] Add an entry to CHANGELOG.md under the ## main section.

Kai-W avatar Mar 25 '24 16:03 Kai-W

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.79%. Comparing base (f24dfe6) to head (789f158).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3898      +/-   ##
==========================================
+ Coverage   87.50%   87.79%   +0.28%     
==========================================
  Files         265      265              
  Lines       37970    37974       +4     
  Branches     2409     2402       -7     
==========================================
+ Hits        33227    33339     +112     
+ Misses       3665     3553     -112     
- Partials     1078     1082       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 31 '24 10:03 codecov-commenter

@Kai-W can you resolve conflict and prepare this PR to be merged? I want to move forward with the breaking changes of version 5.

HarelM avatar Oct 22 '24 11:10 HarelM

I rebased the branch, but i dont know why the windows rendert test 0 is failing. @HarelM can you look at it?

Kai-W avatar Oct 22 '24 14:10 Kai-W