maplibre-gl-js icon indicating copy to clipboard operation
maplibre-gl-js copied to clipboard

Don't skip on expirationTime == 0

Open Schlepptop opened this issue 1 year ago • 2 comments

Fixes #3784

Launch Checklist

  • [x] Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • [x] Briefly describe the changes in this PR.
  • [x] Link to related issues.
  • [x] Include before/after visuals or gifs if this PR includes visual changes.
  • [x] Write tests for all new functionality.
  • [x] Document any changes to public APIs.
  • [ ] Post benchmark scores.
  • [x] Add an entry to CHANGELOG.md under the ## main section.

Schlepptop avatar Mar 04 '24 21:03 Schlepptop

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.76%. Comparing base (ee0450c) to head (81281fb). Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3785      +/-   ##
==========================================
+ Coverage   86.64%   86.76%   +0.11%     
==========================================
  Files         240      240              
  Lines       32273    32273              
  Branches     1977     1981       +4     
==========================================
+ Hits        27963    28001      +38     
+ Misses       3376     3333      -43     
- Partials      934      939       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 04 '24 21:03 codecov-commenter

Thanks for taking the time to open this PR! Can you please add a unit test to cover this case?

HarelM avatar Mar 05 '24 20:03 HarelM