maplibre-gl-js icon indicating copy to clipboard operation
maplibre-gl-js copied to clipboard

Fix parameter types of Map.querySourceFeatures

Open cns-solutions-admin opened this issue 2 years ago • 2 comments

Fixes #1393

cns-solutions-admin avatar Jul 26 '22 09:07 cns-solutions-admin

Bundle size report:

Size Change: +2 B Total Size Before: 204 kB Total Size After: 204 kB

Output file Before After Change
maplibre-gl.js 195 kB 195 kB +2 B
maplibre-gl.css 9.03 kB 9.03 kB 0 B
ℹ️ View Details No major changes

github-actions[bot] avatar Jul 26 '22 09:07 github-actions[bot]

Don't think the integration test timeout is caused by this change!

cns-solutions-admin avatar Jul 26 '22 09:07 cns-solutions-admin

After checking the code, FilterSpecification is the correct parameter type. Regarding params: there are also other methods with params - if this is desired that should be done in another PR while taking care that no circular (import-) dependencies are created.

cns-solutions-admin avatar Sep 21 '22 13:09 cns-solutions-admin

Thanks!! Feel free to continue type improving.. 😀

HarelM avatar Sep 21 '22 14:09 HarelM

Just to double check, this is not a breaking change, right?

wipfli avatar Sep 21 '22 14:09 wipfli

It's not a change, just types, code and docs alignment.

HarelM avatar Sep 21 '22 14:09 HarelM