monostack icon indicating copy to clipboard operation
monostack copied to clipboard

Doesn't play nice with Jetpack share buttons

Open ghost opened this issue 6 years ago • 1 comments

Firstly, let me say I love your theme. Unfortunately there's an issue with its syntax highlighter.

Here's what it looks like with the Jetpack plugin's share buttons enabled.. I also have my inspector going so you can see even more details.

https://digitaltekkie.com/wp-content/uploads/2019/02/Capture.jpg

So essentially what's going is that any plugin that inserts a preposition will be surrounded with tags, even if it's part of a html tag="" property that was parsed by a plugin. For me that is an issue. Plenty of plugins out there parse text to the DOM. The syntax highlighter should take that into account and not interfere with what they output. Is there any way you could take a look at this?

If you're interested I can go into the JS and see if I can muster up a work-around. I wanted to get your thoughts first.

ghost avatar Feb 03 '19 01:02 ghost

@kevintesar This is a fantastic find! Thank you. I'd love your help with it. Please send me a PR or attach your changes here in this issue.

mapk avatar Feb 08 '19 21:02 mapk