mapillary-js icon indicating copy to clipboard operation
mapillary-js copied to clipboard

Incorrect imagery display on Firefox

Open willemarcel opened this issue 4 years ago • 8 comments

Basic information

After some minutes of use of Mapillary website or using the Mapillary layer on iD editor (osm.org), the images start to be rendered incorrectly.

MapillaryJS version: current System/Browser: macOS BigSur / Firefox 91.0.1 (64-bit)

Steps to Reproduce Behavior

  1. Go to the Mapillary website, start navigating on the images, or start using the Mapillary layer on osm.org iD editor.

Expected behavior

...

Actual behavior

Screenshot 2021-08-19 at 08 56 52 Screenshot 2021-08-19 at 08 57 32

willemarcel avatar Aug 19 '21 12:08 willemarcel

Thanks for reporting.

I cannot reproduce this behavior. Can you share more detailed steps or a screen capture showing how to reproduce? Can you share image IDs for areas where the problem occurs?

oscarlorentzon avatar Aug 23 '21 08:08 oscarlorentzon

@willemarcel Does this problem still occur?

oscarlorentzon avatar Nov 08 '21 14:11 oscarlorentzon

@oscarlorentzon I used mapillary for a long time session today both in mapillary.com and in osm.org and the errors didn't happen.

willemarcel avatar Nov 08 '21 14:11 willemarcel

The problem occurred 2 times again, but every time I try to record my screen, the error didn't happen.

willemarcel avatar Nov 12 '21 12:11 willemarcel

OK, thanks for notifying. It would be great if you could share an image ID/link next time it happens. A video (with Firefox dev tools opened) would also help.

oscarlorentzon avatar Nov 15 '21 14:11 oscarlorentzon

@willemarcel Can you make sure to open the developer tools in your browser the next time the error occurs and grab a screenshot of the console output? That would help with debugging.

Also, can you describe in more details the exact steps you take for the error to occur and provide an image ID? I can't seem to reproduce it.

oscarlorentzon avatar Nov 24 '21 07:11 oscarlorentzon

Some images from errors in the console image

image

This one happened in another session: image

willemarcel avatar Nov 29 '21 12:11 willemarcel

#462, #480, and “[BUG] Image Zoom Bug in the Web Viewer” may be all connected. For the sake of completeness, I also get the following warning message in the browser console. Yet, I do not think this causes anything.

WebGL warning: texImage: Alpha-premult and y-flip are deprecated for non-DOM-Element uploads. 4 main.d70d902b592f3e7b.js:284:952366

:thinking: Call me naive but searching the mapillary-js repo for glFinish or gl.finishand similar has turned up nothing. Maybe mapillary-js is not the place to look into. However, my gut feeling tells me that this is some kind of synchronization issue, be it because of some lack of glFinish() or some other synchronization with the HTML canvas.

JakeSmarter avatar Oct 11 '23 15:10 JakeSmarter