OpenSfM icon indicating copy to clipboard operation
OpenSfM copied to clipboard

Fix GCP handling

Open YanNoun opened this issue 4 months ago • 2 comments

This PR fixes the GCP handling which was not great :

  • Quality report and triangulation used different sets of thresholds. We now use 0.050 consistently, which makes room for "enforcing" GCPs while allowing removal of complete outliers.
  • Bias compensation is now only activated in BA if there's GCPs
  • LS Alignment uses GCPs OR GPS but NOT BOTH together as there's usually no guarantee of consistency between their respective coordinate system
  • GCP weighting has been tweaked a bit

This fixes datasdets with problematic GCPs : BEFORE : GCP error of 7m report_speedup.pdf

THIS BRANCH : GCP error of 0.09m report_gcp_fix.pdf

Branch is on top of optim-large

YanNoun avatar Aug 21 '25 15:08 YanNoun

Just rebased on master.

YanNoun avatar Aug 28 '25 13:08 YanNoun

@paulinus has imported this pull request. If you are a Meta employee, you can view this in D81898979.

facebook-github-bot avatar Sep 08 '25 07:09 facebook-github-bot