OpenSfM icon indicating copy to clipboard operation
OpenSfM copied to clipboard

Remove build warnings

Open YanNoun opened this issue 7 months ago • 1 comments

This PR removes all the annoying build warnings that we had by :

  • Setting CMake policy
  • Add C++ warning ignores in third-party libraries only, since we're very unlikely to touch this code ever again
  • Fix the actual warnings in the rest of OpenSfM code

YanNoun avatar May 21 '25 14:05 YanNoun

Hi @YanNoun!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar May 23 '25 17:05 facebook-github-bot

@fabianschenk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 24 '25 15:06 facebook-github-bot

@fabianschenk merged this pull request in mapillary/OpenSfM@752e008c185d2be89189c02c11139bb0466a6ea7.

facebook-github-bot avatar Jun 25 '25 12:06 facebook-github-bot