OpenSfM icon indicating copy to clipboard operation
OpenSfM copied to clipboard

returning norm_coords instead of px_coords in pixelToNormalizedCoordi…

Open oaa3wf opened this issue 1 year ago • 1 comments

…natesMany

Attempting to fix issue create here: https://github.com/mapillary/OpenSfM/issues/1030#issue-2046628484

oaa3wf avatar Dec 18 '23 14:12 oaa3wf

Hi @oaa3wf!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 18 '23 14:12 facebook-github-bot

Hey @fabianschenk, can you take a look at this? That looks like an important bug fix to me.

kielnino avatar Mar 16 '24 15:03 kielnino

@fabianschenk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 18 '24 07:03 facebook-github-bot

Hi @oaa3wf, Thanks for the fix. This indeed was a bug. I'll try to land the fix asap

fabianschenk avatar Mar 18 '24 12:03 fabianschenk