mapfish-print icon indicating copy to clipboard operation
mapfish-print copied to clipboard

SpringBoot3 / Springframework6 version

Open jusabatier opened this issue 2 years ago • 1 comments

Hi,

I'm trying to make this lib compatible with SpringBoot3/Springframework6 as I try to upgrade some of our local apps that uses it.

Here is what I already done : https://github.com/jusabatier/mapfish-print/tree/spring6

I still have some problems because I'm familiar with maven, not with gradle :

  • Had to disable :docs:buildDocs here : https://github.com/jusabatier/mapfish-print/blob/spring6/Dockerfile#L35

Because I have an error that I fail to solve :

Exception in thread "main" java.lang.IllegalArgumentException: Unable to find javadoc for method 'setParser' in '!geojsonLayerParser'

  • When compiling with make dist, I try to include the generated jar file in another project, but it doesn't embed jasper, metrics and geotools libs so I have to reimport them in the project. Is it normal ? With previous versions it was embed in the generated jar.

Can you help me with this (especially the second) ?

And feel free to feedback about what I did.

jusabatier avatar Dec 08 '23 15:12 jusabatier

It looks like resources files are also missing from jar :

Could not resolve placeholder 'httpRequest.fetchRetry.maxNumber' in value "${httpRequest.fetchRetry.maxNumber}"

jusabatier@ThinkPad-E15-Gen-2-Julien:~/Workspace/Eclipse/Projets/mapfish-print$ grep -Rnw '.' -e 'httpRequest.fetchRetry.maxNumber'
./core/src/main/resources/mapfish-spring.properties:51:httpRequest.fetchRetry.maxNumber=3
./core/src/main/java/org/mapfish/print/processor/map/CreateMapProcessor.java:109:  @Value("${httpRequest.fetchRetry.maxNumber}")
./core/bin/main/mapfish-spring.properties:51:httpRequest.fetchRetry.maxNumber=3

jusabatier avatar Dec 08 '23 15:12 jusabatier