Terrain Sets / Terrain Labels: Little Findings & Improvements

[UliAbo]

Recently I worked quite intensively with Terrain Labels / Terrain Sets and this is what I've found out plus ideas for improvements. Let me know if I have overlooked something.

1. Pattern list is not updated on Undo ~~Labels are not updated by CTRL+Z~~ AsIs: When deleting a TerrainSet Label, then in the Patterns View, the corresponding Pattern is switched, which is correct. But when then hitting "Undo" via CTRL+Z, then the Label comes back, but the Pattern is still switched as the Label would not exist.

2. Keybinding for Erase Terrain Please add the option to make the function "Erase Terrain" be assigned with a keybinding.

3. Hand Pan Tool for Tilesets On the Map, I use the "hand pan" tool (holding SPACE) a lot to navigate. Add this function please also for the view when editing Tilesets. That would be helpful for rather big Tilesets where you are zoomed in quite close.

4. Show Grid for Tilesets I have put "Show Grid" on keybinding CTRL+G which works totally fine in the MapView. Why doesn't it work in the Tileset View? Why can't I toggle the Grid there?

Specifications:

• OS: Windows 10
• Tiled Version v.1.8.5

[eishiya]

For (1), I think a clearer title would be "Pattern list is not updated on Undo"

(4): There's no grid in the Tileset view because tiles aren't always displayed on a grid, and tile sizes can vary. Instead, there's a permanent 1px space between tiles. While this works well for tightly-packed orthographic tilesets, it's not very clear on tilesets that have transparency around the tiles or have a lot of empty tiles. I think rather than a grid, I'd like to see some sort of tile image box indication so that it's clear where differently sized tiles' transparency regions begin and end; these boxes would add up to a grid on uniformly sized tilesets anyway.

These are all rather distinct features, I think they might be easier to manage if split off into individual issues.

[bjorn]

There's no grid in the Tileset view because tiles aren't always displayed on a grid, and tile sizes can vary. Instead, there's a permanent 1px space between tiles.

Well, this 1px space is still called a "grid" and can currently be toggled through the context menu on the tileset view. The thing is that whether the grid should be enabled in the tileset view or on the map view are still different options, and the View > Show Grid option is the one for the map view.

3. Hand Pan Tool for Tilesets

Regarding this one, you can actually pan using the middle mouse button in the Tilesets view. The problem with Space is that it works without clicking, so it really has not enough context to know which view is meant (and I'm not sure it makes sense to only support panning tileset view with Space in the Tileset Editor). A solution here might be to require clicking, then holding Space could work together with click in both map and tileset views.

[UliAbo]

Thanks for the feedback both of you.

(4) I got with the grid. I thought it would be easy to change but I got your points. Other things are more important (and hopefully easier to implement).

@eishiya (1) I changed the title.

@bjorn (3) I would highly appreciate and also recommend to change the default behavior for both map and tileset view of the handpan to: "Hold SPACE + click with Left Mouse Button to drag". This is also the default behavior of Photoshop and Aseprite (and also other software iirc). With this improved behavior, this is also nice for users (like me) of graphic tablets (Wacom, etc.) because it's much more convenient + precise to actually need to click and drag also with a pen. And again like in Photoshop and Aseprite.

[eishiya]

+1 for space + drag, rather than space + move. I'd rather not release Space just to move my mouse over so I can pan further. I habitually click anyway, since I also use Aseprite and Photoshop a lot xP

[bjorn]

and also other software iirc

Both GIMP and Inkscape do not require the user to click when panning with Space, and this is what I based the behavior of Tiled on. But I think the multi-view setup (map and tileset) means we should switch to requiring the click.