tiled icon indicating copy to clipboard operation
tiled copied to clipboard

Extension Mismatch dialog: Ask in the main text

Open encukou opened this issue 4 years ago • 4 comments

The MessageBox shows Yes/No buttons, but the question it is asking is hidden in the fine print. I believe it would make more sense to ask questions first, and explain later.

encukou avatar Oct 26 '19 18:10 encukou

Looking further, I see this happens on other dialogs as well. Do you think it's an issue?

encukou avatar Oct 26 '19 21:10 encukou

Looking further, I see this happens on other dialogs as well. Do you think it's an issue?

I guess it could be an issue. I think your suggestion definitely make sense, but it depends a little on what other applications do to see what the user could really expect. I noticed the example in the QMessageBox documentation also asks the question in the informative text:

image

I do think this only really matters on macOS, I'm not sure if the message box has different formatting of the text on other platforms. I also think for Tiled 1.3 it's more important to keep the string freeze now, so I'd merge this after branching.

Feel free to extend this pull request with fixes to the other dialogs you've noticed this on.

bjorn avatar Oct 28 '19 08:10 bjorn

Ah. If this is usual on Macs, it's probably not worth fixing, though it still seems weird to me. But, I certainly won't be able to prioritize working on this :( And changing just one dialog is probably worse than not chaging anything Please re-open if you think it's worth fixing.

encukou avatar Oct 29 '19 10:10 encukou

I don't know what's usual on macOS. The QMessageBox example may not be ideal either. In the case of having unsaved changes, the usual popup seems rather more helpful:

Screen Shot 2019-10-29 at 11 56 00

Though it is true that the question is in the title, like you are suggesting.

And changing just one dialog is probably worse than not chaging anything Please re-open if you think it's worth fixing.

Yeah, I'll reopen since I think it's worth improving this, but I'll check the other cases of "informative text" before merging.

bjorn avatar Oct 29 '19 11:10 bjorn