tiled icon indicating copy to clipboard operation
tiled copied to clipboard

Published 20 hours ago • verified publisher icon mapeditor

GoTo Tile

Open MoctezumaDev opened this issue 8 years ago • 7 comments

Hey I added the goto tile functionality #1367. I'm sure I might need to reorganize or refactor some part of the code but we can start from here with the review.

MoctezumaDev avatar Feb 15 '17 21:02 MoctezumaDev

Hey @leonidax, why close it? If you want to update it with cleanups, please force-push to your feature/gototile branch to update this pull request.

bjorn avatar Feb 23 '17 09:02 bjorn

Ok, I'll do it that way.

MoctezumaDev avatar Feb 23 '17 10:02 MoctezumaDev

@leonidax are you still working on this? If not, can I help in getting this one merged?

ketanhwr avatar Mar 13 '17 00:03 ketanhwr

Hi @ketanhwr thanks for asking but I think I would rather finish it myself. I might need some help I have been pushing this for later since the build seems to fail in Linux and I have not had time to setup a Linux machine, but I suspect it's something related to the namespaces.

MoctezumaDev avatar Mar 13 '17 06:03 MoctezumaDev

The build for Linux is failing since you've not added the new files in tiled.pro. Therefore they aren't getting compiled. Anyway, thanks for your reply! :)

ketanhwr avatar Mar 13 '17 06:03 ketanhwr

@ketanhwr you are right this might be the problem thanks for pointing that out, I just checked the job configuration and it uses qmake and the .pro file instead of the .qbs file.

MoctezumaDev avatar Mar 13 '17 07:03 MoctezumaDev

I just checked the job configuration and it uses qmake and the .pro file instead of the .qbs file.

Yep, it's annoying so I've just opened #1484 for fixing that. Until that is closed, we need to keep the file list in the qmake projects up to date as well.

bjorn avatar Mar 13 '17 08:03 bjorn