vtshaver icon indicating copy to clipboard operation
vtshaver copied to clipboard

Published 20 hours ago • verified publisher icon mapbox

use libnu mason dependency instead vendored src

Open axrj opened this issue 2 years ago • 2 comments

  • Fixes #60
  • Adds libnu 1.8 as mason dependency and updates build accordingly
  • Removes vendored source code of libnu

make test fails with missing symbol called error on mac with both main and the PR branch equally. tests pass on CI though.

Todo:

  • [ ] Test with api-vectortiles
  • [ ] Maybe check test failure on mac.

axrj avatar Jul 26 '22 14:07 axrj

TBD - from slack convo What does make test do that is different from Travis builds? Which missing symbol is missing on main? It could be a symbol which is undefined but not used in shaving, in which case it would be ok.

sofiapag avatar Jul 28 '22 05:07 sofiapag

ah. symbol not found in flat namespace '__ZTVN4mbgl12LayerFactoryE' basically mbgl.LayerFactory I don't think this is used anywhere but a reference is being compiled on darwin platform. Not sure where yet.

axrj avatar Jul 28 '22 14:07 axrj