secret-shield icon indicating copy to clipboard operation
secret-shield copied to clipboard

I should not have to globally install this module

Open rclark opened this issue 4 years ago • 3 comments

Why isn't installing secret-shield as a dependency in my repository sufficient? What's driving the demand that I manage a global npm secret-shield installation?

rclark avatar Mar 14 '20 18:03 rclark

Hi @rclark, have you seen these instructions to install secret-shield in your repo? If yes what issues have you run into with this? https://github.com/mapbox/secret-shield/blob/master/docs/enabledRepositories.md#how-to-install-in-your-repository

vsmart avatar Apr 01 '20 11:04 vsmart

Yes, that documentation is incomplete, because when I make a commit, the hook issues this error:

ERROR! You must have secret-shield installed and configured globally to commit to this repository. To set up secret-shield, follow these instructions: https://github.com/mapbox/secret-shield/blob/master/docs/enabledBadge.md

rclark avatar Apr 01 '20 16:04 rclark

We also ran into problems with projects using pre-commit:

$ pre-commit install
[ERROR] Cowardly refusing to install hooks with `core.hooksPath` set.
hint: `git config --unset-all core.hooksPath`

I had to remove secret-shield from my global git hooks.

rreusser avatar May 24 '22 17:05 rreusser