mbxmapkit
mbxmapkit copied to clipboard
mapbox
move away from info button in sample app
Minor, but this info button is the exact same control we use in the iOS SDK to denote map attribution. It's probably what we'll move to when we adopt attribution in this project (#54). We should make a custom text button or graphic or something.
Attribution is actually included and working as the bottom item on the action sheet which comes up from the info button. Having map screen selection mixed in with the attribution does muddy the water a bit though I suppose.
The reason I went with a button triggering an action sheet is that it allows for a very simple switch...case statement in the action sheet callback to handle all the map re-configuration. To do something similar with a UITableView or the like would result in a lot of additional code and complexity in the sample app. I suppose that wouldn't necessarily be a bad thing though, because perhaps it would be more familiar to people.
Do you have anything in mind which might strike a better balance between code readability and UI design?
Attribution is actually included and working
Yeah, I did notice that, but I don't think we should hold up 0.3.0 for the relatively higher-friction #54 UI element.
I'm also just trying to get ahead of the inevitable attribution info button when #54 is addressed, which will require addressing this info button.
Do you have anything in mind which might strike a better balance between code readability and UI design?
I think a button's ok, but something simple like a gear or even a white round rect with 50% opacity down in the corner should be fine.
Ah, okay. I think I follow you. My vote is let's not worry about that for now. If and when it becomes more of a problem, then we can figure out what to do about it.
Cool. Let's leave it on the milestone for now, reevaluate later just to be sure, and postpone if necessary.