mapbox.js icon indicating copy to clipboard operation
mapbox.js copied to clipboard

support limit parameter in geocoder

Open tomap opened this issue 6 years ago • 3 comments

geocoder api supports between 1 and 10 search results. Default value is 5. Now, it's possible to set the limit

tomap avatar May 10 '18 13:05 tomap

Hey, you published a new version recently, could you look at the PR?

tomap avatar May 30 '19 19:05 tomap

Thanks for flagging this, @tomap. As far as I can tell this looks like a pretty straightforward change, but before we approve/merge would you mind doing the following two things:

  • [ ] add a unit test in https://github.com/mapbox/mapbox.js/blob/publisher-production/test/spec/geocoder.js for this new query parameter
  • [ ] update the CHANGELOG.md to reflect this addition

riastrad avatar Mar 03 '21 21:03 riastrad

4 years later, would you mind doing it? I did half the job. I would be very glad if you did the rest of the job :)

tomap avatar Jan 14 '22 20:01 tomap