mapbox-navigation-android icon indicating copy to clipboard operation
mapbox-navigation-android copied to clipboard

[Drop-In] Remove `@Experimental` annotation from drop in related files

Open abhishek1508 opened this issue 2 years ago • 1 comments

Description

The implementation covers

  • removing @ExperimentalPreviewMapboxNavigationAPI annotation from all internal and public files related to libnavui-dropin module.
  • removing @ExperimentalPreviewMapboxNavigationAPI from all new components that are exposed outside libnavui-dropin module. For ex: RouteLineComponent, RouteLineComponentContract, RecenterButtonComponent etc. It shouldn't be an issue removing the experimental annotation, since these components and their respective contracts are hosted inside internal package.
  • not removing @ExperimentalPreviewMapboxNavigationAPI from MapboxExtendableButton and it's usage across the SDK. This is because in some cases it's still not possible to render circular buttons with this widget. Issue was reported here
  • not removing @ExperimentalPreviewMapboxNavigationAPI from any files related to ComponentInstaller and it's usage. ComponentInstaller could be subject to modifications and we need to play more with them before declaring them stable.

abhishek1508 avatar Oct 11 '22 16:10 abhishek1508

Codecov Report

Merging #6471 (c8ca9a4) into main (a45f7d4) will increase coverage by 0.07%. The diff coverage is n/a.

:exclamation: Current head c8ca9a4 differs from pull request most recent head 95f2c30. Consider uploading reports for the commit 95f2c30 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #6471      +/-   ##
============================================
+ Coverage     70.26%   70.33%   +0.07%     
+ Complexity     4918     4907      -11     
============================================
  Files           722      717       -5     
  Lines         28044    27947      -97     
  Branches       3305     3295      -10     
============================================
- Hits          19705    19657      -48     
+ Misses         7064     7012      -52     
- Partials       1275     1278       +3     
Impacted Files Coverage Δ
...mapbox/navigation/navigator/internal/TripStatus.kt 0.00% <0.00%> (-100.00%) :arrow_down:
...com/mapbox/navigation/core/history/HistoryFiles.kt 60.00% <0.00%> (-8.43%) :arrow_down:
...x/navigation/core/history/MapboxHistoryRecorder.kt 42.85% <0.00%> (-4.97%) :arrow_down:
...x/navigation/ui/maps/building/BuildingProcessor.kt 65.62% <0.00%> (-2.38%) :arrow_down:
...ava/com/mapbox/navigation/core/MapboxNavigation.kt 67.85% <0.00%> (-1.81%) :arrow_down:
...box/navigation/core/NavigationComponentProvider.kt 51.35% <0.00%> (-1.43%) :arrow_down:
...box/navigation/ui/voice/api/MapboxAudioGuidance.kt 79.68% <0.00%> (-0.32%) :arrow_down:
...om/mapbox/navigation/base/route/NavigationRoute.kt 51.92% <0.00%> (-0.24%) :arrow_down:
.../mapbox/navigation/route/internal/RouterWrapper.kt 80.35% <0.00%> (-0.12%) :arrow_down:
...n/dropin/navigationview/MapboxNavigationViewApi.kt 92.59% <0.00%> (-0.10%) :arrow_down:
... and 19 more

codecov[bot] avatar Oct 11 '22 16:10 codecov[bot]

@abhishek1508 The changes that remove @Experimental annotation are great. However, I have a couple of questions about some other changes:

  • Why are we moving and modifying ComponentInstaller classes? I think these changes are outside the scope of this PR and should be done separately.
  • Why are we removing class description comments?

tomaszrybakiewicz avatar Nov 09 '22 17:11 tomaszrybakiewicz

@abhishek1508 The changes that remove @Experimental annotation are great. However, I have a couple of questions about some other changes:

  • Why are we moving and modifying ComponentInstaller classes? I think these changes are outside the scope of this PR and should be done separately.

Answered here

  • Why are we removing class description comments?

Answered here

@tomaszrybakiewicz

abhishek1508 avatar Nov 09 '22 18:11 abhishek1508

@tomaszrybakiewicz All suggestions have been applied. PTAL and let me know if any other changes are needed.

abhishek1508 avatar Nov 09 '22 20:11 abhishek1508