mapbox-navigation-android icon indicating copy to clipboard operation
mapbox-navigation-android copied to clipboard

Published 20 hours ago • verified publisher icon mapbox

[Android Auto] Remove SearchEngine from `MainCarContext` constructor

Open kmadsen opened this issue 2 years ago • 3 comments

The search api is subject to change and it cannot be in the android auto api. Remove it and resolve the issues as internal implementations.

https://github.com/mapbox/mapbox-navigation-android/blob/bf0f61f96c3942b28daea4aa010238380b20acb3/qa-test-app/src/main/java/com/mapbox/navigation/qa_test_app/car/MainCarSession.kt#L71-L77

kmadsen avatar Aug 11 '22 23:08 kmadsen

cc: @Zayankovsky

kmadsen avatar Aug 11 '22 23:08 kmadsen

Referencing a larger issue https://github.com/mapbox/mapbox-navigation-android/issues/5786

I think these issues should be solved separately but they are related.

kmadsen avatar Aug 11 '22 23:08 kmadsen

It should also not be required to integrate the CarSearchLocationProvider in order to make android auto work.

https://github.com/mapbox/mapbox-navigation-android/blob/bf0f61f96c3942b28daea4aa010238380b20acb3/qa-test-app/src/main/java/com/mapbox/navigation/qa_test_app/car/search/CarSearchLocationProvider.kt#L18-L20

kmadsen avatar Aug 12 '22 01:08 kmadsen