mapbox-navigation-android icon indicating copy to clipboard operation
mapbox-navigation-android copied to clipboard

Bump Kotlin, Coroutines and Gradle dependency versions to `1.6.21`, `1.6.2` and `7.2.1` respectively

Open Guardiola31337 opened this issue 2 years ago • 2 comments

Description

Follow up from https://github.com/mapbox/mapbox-navigation-android/pull/5743#issuecomment-1143993442

  • Bumps Kotlin, Coroutines and Gradle dependency versions to 1.6.21, 1.6.2 and 7.2.1 respectively

Opening this as a Draft as there are some UI tests failing:

CameraComponentTest. camera frame is not updated on subsequent location updates
CameraComponentTest. when route progress updates in arrival camera mode should update
RecenterButtonComponentTest. when camera mode is not idle recenter is not visible
RecenterButtonComponentTest. when navigation state is route preview recenter is not visible
TripSessionStarterStateControllerTest. EnableReplayTripSession will only startReplayTripSession for ActiveGuidance
TripSessionStarterStateControllerTest. EnableReplayTripSession will startReplayTripSession
TripSessionStarterStateControllerTest. EnableTripSession will restart a trip session when replay is enabled
TripSessionStarterStateControllerTest. startTripSession if location permissions are granted

We should also migrate other things like for example runBlockingTest which has been @Deprecated.

cc @abhishek1508 @tomaszrybakiewicz @kmadsen @cafesilencio @RingerJK

Guardiola31337 avatar Jun 03 '22 19:06 Guardiola31337

internal-instrumentation-tests are also ❌

06-03 11:39:05.271: E/TestRunner(22253): failed: checkNotificationContent(com.mapbox.navigation.core.trip.service.TripServiceTest)
06-03 11:39:05.271: E/TestRunner(22253): ----- begin exception -----
06-03 11:39:05.271: E/TestRunner(22253): java.lang.RuntimeException: Unable to resolve activity for: Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] cmp=com.mapbox.navigation.core.test/com.mapbox.navigation.core.tests.activity.TripServiceActivity }
06-03 11:39:05.271: E/TestRunner(22253): 	at androidx.test.core.app.InstrumentationActivityInvoker.startActivity(InstrumentationActivityInvoker.java:402)
06-03 11:39:05.271: E/TestRunner(22253): 	at androidx.test.core.app.InstrumentationActivityInvoker.startActivity(InstrumentationActivityInvoker.java:437)
06-03 11:39:05.271: E/TestRunner(22253): 	at androidx.test.core.app.ActivityScenario.launchInternal(ActivityScenario.java:265)
06-03 11:39:05.271: E/TestRunner(22253): 	at androidx.test.core.app.ActivityScenario.launch(ActivityScenario.java:195)
06-03 11:39:05.271: E/TestRunner(22253): 	at androidx.test.ext.junit.rules.ActivityScenarioRule.lambda$new$0$ActivityScenarioRule(ActivityScenarioRule.java:70)
06-03 11:39:05.271: E/TestRunner(22253): 	at androidx.test.ext.junit.rules.ActivityScenarioRule$$Lambda$0.get(ActivityScenarioRule.java:70)
06-03 11:39:05.271: E/TestRunner(22253): 	at androidx.test.ext.junit.rules.ActivityScenarioRule.before(ActivityScenarioRule.java:103)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
06-03 11:39:05.271: E/TestRunner(22253): 	at com.adevinta.android.barista.rule.cleardata.ClearDatabaseRule$apply$1.evaluate(ClearDatabaseRule.kt:31)
06-03 11:39:05.271: E/TestRunner(22253): 	at com.adevinta.android.barista.rule.cleardata.ClearPreferencesRule$1.evaluate(ClearPreferencesRule.java:26)
06-03 11:39:05.271: E/TestRunner(22253): 	at com.adevinta.android.barista.rule.cleardata.ClearFilesRule$apply$1.evaluate(ClearFilesRule.kt:25)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
06-03 11:39:05.271: E/TestRunner(22253): 	at androidx.test.ext.junit.runners.AndroidJUnit4.run(AndroidJUnit4.java:162)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.Suite.runChild(Suite.java:128)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.Suite.runChild(Suite.java:27)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
06-03 11:39:05.271: E/TestRunner(22253): 	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
06-03 11:39:05.271: E/TestRunner(22253): 	at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
06-03 11:39:05.271: E/TestRunner(22253): 	at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:444)
06-03 11:39:05.271: E/TestRunner(22253): 	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2205)
06-03 11:39:05.271: E/TestRunner(22253): ----- end exception -----

Guardiola31337 avatar Jun 03 '22 19:06 Guardiola31337

https://github.com/mapbox/mapbox-navigation-android/pull/5904#issuecomment-1146299411

This is a known flaky test.

abhishek1508 avatar Jun 03 '22 19:06 abhishek1508

Superseded by https://github.com/mapbox/mapbox-navigation-android/pull/6179

Closing here.

cc @RingerJK

Guardiola31337 avatar Aug 17 '22 10:08 Guardiola31337