mapbox-navigation-android icon indicating copy to clipboard operation
mapbox-navigation-android copied to clipboard
verified publisher icon mapbox

MapboxSpeedLimitView empty does not show after being removed

Open kmadsen opened this issue 3 years ago • 3 comments

Considering this a minor issue. But there does not seem to be a way to restore the previous state for the speed limit view. This becomes apparent when attempting to remove/add the view at runtime.

Steps to trigger behavior

  1. Create a view with MapboxSpeedLimitView
  2. Get a speed limit, notice valid speed limit
  3. Go to location without a speed limit, notice -- empty speed limit
  4. Swap views

Expected behavior

The speed limit view with -- should re-appear. Or there should be a way to restore the state

Actual behavior

https://user-images.githubusercontent.com/3021882/155822243-22cc8943-6463-45ae-b6cd-812dde7fad54.mp4

kmadsen avatar Feb 26 '22 01:02 kmadsen

This could be due to the speed limit sign type being null when the speed limit view is first created. The sign type isn't determined until at leas one speed limit value is rendered. There is a PR to address this here: https://github.com/mapbox/mapbox-navigation-android/pull/5549

cafesilencio avatar Mar 08 '22 22:03 cafesilencio

@kmadsen Can we retest this and close if it is fixed by the PR mentioned above?

abhishek1508 avatar Mar 12 '22 20:03 abhishek1508

@kmadsen is this still relevant?

LukasPaczos avatar Apr 01 '22 15:04 LukasPaczos