mapbox-navigation-android icon indicating copy to clipboard operation
mapbox-navigation-android copied to clipboard

[Android] Retry logic to network layer

Open RingerJK opened this issue 5 years ago • 5 comments

Catching from slack discussion:

networking retries, that logic is really good to have on the networking layer

cc @kmadsen @mapbox/navigation-android

RingerJK avatar Jun 24 '20 10:06 RingerJK

Started looking at this some and MapboxServices would be a good place

kmadsen avatar Jun 24 '20 14:06 kmadsen

@kmadsen yeah, it's a great option! BTW if we need that we could make it internally in SDK, and later apply external library retry-feature.

RingerJK avatar Jun 25 '20 16:06 RingerJK

mapbox-java issue https://github.com/mapbox/mapbox-java/issues/1164

RingerJK avatar Aug 07 '20 12:08 RingerJK

MapboxServices are rather stateless, it's only an abstraction to make a request. IMO, if we were to implement a retry logic, SDK should be responsible for driving this experience and letting the dev customize it.

LukasPaczos avatar Aug 07 '20 12:08 LukasPaczos

IMO, if we were to implement a retry logic, SDK should be responsible for driving this experience and letting the dev customize it.

actually I was thinking about it. And retry logic might be handled by SDK, agree. But still would be great to expose MapboxServices API to make retry calls.

RingerJK avatar Aug 07 '20 12:08 RingerJK