mapbox-maps-ios icon indicating copy to clipboard operation
mapbox-maps-ios copied to clipboard

Point for location outside of screen bounds

Open drewwashere opened this issue 2 years ago • 1 comments

New Feature

A change was made that prevents points from being calculated by location if the position is out of the bounds of the view. https://github.com/mapbox/mapbox-maps-ios/commit/1ae43c46b8fa8cbffc344fea261732cd5a2b5901 There are times when locations are still needed outside the bounds of a view for when elements are drawn that bridge the on/off screen space.
The existing function can remain but a separate function is needed the doesn't have the same bound restrictions. Or any publicly accessible location to point conversion that references the underlying map.

Why

We cannot upgrade our integration of mapbox because this causes a regression. We need to be able to calculate positions of off screen elements to correctly draw bridging elements on top of the map.

drewwashere avatar May 11 '23 21:05 drewwashere

I have the same issue. I've made a fork and introduced an absolutePoint call alongside the point function that does not fit it to the screen size. It works fine for my purpose.

I would be happy to create a pull request for this if it's not considered too much of a hack.

jfamiglietti avatar Feb 04 '24 01:02 jfamiglietti