mapbox-maps-ios icon indicating copy to clipboard operation
mapbox-maps-ios copied to clipboard

Better mocking for `Snapshotter`

Open ZiZasaurus opened this issue 3 years ago • 0 comments

Creating MockMapSnapshotter to mock GL-native snapshot behavior. Also creating MapSnapshotterProtocol for Snapshotter to depend on, rather than MapSnapshotter.

Pull request checklist:

  • [ ] Describe the changes in this PR, especially public API changes.
  • [ ] Include before/after visuals or gifs if this PR includes visual changes.
  • [ ] Write tests for all new functionality. If tests were not written, please explain why.
  • [ ] Add documentation comments for any added or updated public APIs.
  • [ ] Add any new public, top-level symbols to the Jazzy config's custom_categories (scripts/doc-generation/.jazzy.yaml)
  • [ ] Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).
  • [ ] Update the guides (internal access only), README.md, and DEVELOPING.md if their contents are impacted by these changes.
  • [ ] If this PR is a v10.[version] release branch fix / enhancement, merge it to main first and then port to v10.[version] release branch.

PRs must be submitted under the terms of our Contributor License Agreement CLA.

ZiZasaurus avatar Aug 18 '22 14:08 ZiZasaurus