mapbox-maps-flutter icon indicating copy to clipboard operation
mapbox-maps-flutter copied to clipboard

Leverage Turf for Geometry in TileRegionLoadOptions

Open LorenzSchueler opened this issue 1 year ago • 1 comments

Most API use the Turf classes, however TileRegionLoadOptions has a field geometry which is of type Map<String?, Object?>? instead of turf.GeometryType?. Since this is defined in a pigeon generated file and the sources from which those files are generated are not public I'm unfortunately not able to submit a PR. @maios Is there any reason why the field does not use turf.GeometryType or was this just forgotten? https://github.com/mapbox/mapbox-maps-flutter/blob/e688ca96c76c0c58d4dcb7c723bdaf625e41f6b8/lib/src/offline/offline_messenger.dart#L348

Also why is descriptorOptions of type List<TilesetDescriptorOptions?>? and not List<TilesetDescriptorOptions>? ?

LorenzSchueler avatar Jul 04 '24 09:07 LorenzSchueler

Hi @LorenzSchueler, yes it is in our roadmap to fully support strong typed Geometry. I will keep you updated in this GH issue about the progress of this

maios avatar Jul 04 '24 11:07 maios