mapbox-maps-flutter icon indicating copy to clipboard operation
mapbox-maps-flutter copied to clipboard

Web support

Open skreborn opened this issue 2 years ago • 16 comments

The README states that "Web and desktop are not supported" - I'm wondering if that's a limitation as of this moment, or something that you don't intend to support even if the implementation is done by someone?

skreborn avatar Dec 22 '22 09:12 skreborn

@skreborn hi, there is indeed no plan for Web/Desktop at the moment. We haven't considered supporting 3party implementation yet, however contributions are welcome and it could probably indeed happen when the repo is established and ready for it (part of the tooling for codegen etc is still private).

yunikkk avatar Jan 05 '23 16:01 yunikkk

Thank you for your response - I understand. I imagine the first step would be relying on a plugin interface and separate implementation packages instead of putting everything into a single package. I'll keep an eye on the project.

skreborn avatar Jan 05 '23 16:01 skreborn

Wasn't there plans on the mapbox part to have one underlying code base for all platforms ? IE: wasm ?

cedvdb avatar Jan 07 '23 13:01 cedvdb

Having official Flutter plugin for Mapbox with web support would be great.

it could probably indeed happen when the repo is established and ready for it (part of the tooling for codegen etc is still private)

@yunikkk Is there any way community can help?

marianhlavac avatar Mar 01 '23 13:03 marianhlavac

@marianhlavac @yunikkk @skreborn Community already did: https://github.com/flutter-mapbox-gl/maps

This is a fork of the original project from Mapbox. Community did web support, it works well. And this repo resembles the original structure very much - but it differs in one key aspect - the class implementations are all private, thus even if community wanted to port the existing web implementation, it can't.

I am sure the community (myself very much included) would be eager to prepare PRs for web, but Mapbox needs to enable us in doing so.

srmncnk avatar May 05 '23 05:05 srmncnk

any news here?

lukas-h avatar Jul 25 '23 10:07 lukas-h

Six months since any activity here, we would love an update as we're happy to contribute to this feature but can't move from the tobrun's open source package to this one until the web is supported.

aardrop avatar Jan 12 '24 16:01 aardrop

I am also interested in web support for this plugin. Has the stance on web changed?

HHLiftBridge avatar Jan 26 '24 21:01 HHLiftBridge

Our project is unfortunately not compatable with the package mapbox_gl so were also very also interested in web support for this plugin.

LinschotenMelle avatar Feb 15 '24 10:02 LinschotenMelle

We would like to move from mapbox_gl but our application has a web future so please add support for web.

tfvtti avatar Mar 08 '24 15:03 tfvtti

@evil159 any updates on this? Are you willing to support the community with reviewing PRs and get them merged? I don't want to do any work for this repo to just have the PR rejected/ignored

felix-ht avatar Mar 11 '24 13:03 felix-ht

I would love this as well!

Fakerinc avatar Apr 06 '24 23:04 Fakerinc

@evil159 any updates on this? Are you willing to support the community with reviewing PRs and get them merged? I don't want to do any work for this repo to just have the PR rejected/ignored

Exactly, I would also love to support this if it means we can incorporate it into this package.

aardrop avatar May 07 '24 17:05 aardrop

In the meantime ESRI did this: https://pub.dev/packages/arcgis_map_sdk They claim they support web, I haven't checked it out yet though.

srmncnk avatar May 08 '24 06:05 srmncnk

Not to mention https://pub.dev/packages/maplibre_gl.

srmncnk avatar May 08 '24 06:05 srmncnk

We would like to move from mapbox_gl but our application has a web future so please add support for web.

We are very interested in doing the same!

JEThilenius avatar Sep 12 '24 15:09 JEThilenius

Six-month check-in here: I'd love to contribute to getting the web plugged in here, but with @evil159 providing so much support, I don't want to build something that is out of schema or won't be merged.

It's likely that the third-party open-source version won't support upcoming Flutter updates, and we can't move to this version unless it supports the web.

aardrop avatar Oct 14 '24 17:10 aardrop

Hello everyone,

Apologies for the delayed response, and thank you so much for your offer to help implement web support for our Flutter SDK. We really appreciate your enthusiasm and willingness to contribute!

To clarify, we’re open to accepting contributions for web support, but we want to set the right expectations regarding maintenance. While we can introduce web support as an experimental feature, we’re not in a position to guarantee the same level of maintenance and long-term support that we provide for other platforms—at least not until we see higher demand for web usage.

This means web support would remain in an experimental state for the time being, with the possibility of full support in the future if the demand grows.

Since the project originated from our mobile team at Mapbox, the public API is naturally more aligned with mobile workflows. While many concepts are shared between mobile and web, there may be cases where the APIs don’t map perfectly.

To get the conversation started and explore the possibilities, would you be open to creating a proof-of-concept (PoC) pull request? This would give us a solid foundation for discussion and help shape the direction moving forward.

evil159 avatar Oct 15 '24 12:10 evil159

@evil159 Thank you for your response.

My two cents regarding pull requests - it may have changed since I last looked, but doing pull requests is probably impossible due to two reasons:

  • some classes which needed to be overloaded are private
  • you're using pigeon for wrapper code generation but did not disclose the template for it.

Otherwise I imagine we would be thrilled to have web even as an experimental feature. As long as we can contribute to it. It has been this way since the beginning of the flutter package after all.

srmncnk avatar Oct 15 '24 12:10 srmncnk

@srmncnk To enable this we are willing to make the required accommodations in our SDK codebase, for the purposes of PoC I think it's fine to tamper with private APIs, expose private classes etc. Yeah, currently the templates are in another repo, we'll have to move them here for this to work, I don't think it's required on PoC level, it doesn't have to be all-encompassing, just a web view with a map should be good enough, if there will be a way to set style uri/json that will be awesome.

evil159 avatar Oct 15 '24 12:10 evil159

@evil159 So you're saying you're willing to accept PRs that will modify private class names as well? I think we'd still appreciate access to the template though.

srmncnk avatar Oct 15 '24 14:10 srmncnk