mapbox-maps-android icon indicating copy to clipboard operation
mapbox-maps-android copied to clipboard

Fix revapi release check

Open yunikkk opened this issue 3 years ago • 1 comments

Summary of changes

Paired to the https://github.com/mapbox/mapbox-maps-android/pull/1740, started with the PR to the release branch since check was failing there and not on main

Job fails with bunch of breaking changes, all seem to be about internal apis,

======================== animation ========================
Analysis results
----------------

Old API: tmp.OeBsOlxGhh
New API: tmp.6Cq5npkpLL
old: method boolean com.mapbox.maps.plugin.animation.HighLevelAnimatorSet::getStarted()
new: <none>
java.method.removed: Method was removed.
BINARY: BREAKING, SOURCE: BREAKING

old: method void com.mapbox.maps.plugin.animation.HighLevelAnimatorSet::setStarted(boolean)
new: <none>
java.method.removed: Method was removed.
BINARY: BREAKING, SOURCE: BREAKING

======================== gestures ========================
Analysis results
----------------

Old API: tmp.XrSV6hKpQp
New API: tmp.cgX7mHNChE
old: method void com.mapbox.maps.plugin.gestures.GesturesPluginImpl::<init>(android.content.Context, android.util.AttributeSet, float, android.os.Handler)
new: method void com.mapbox.maps.plugin.gestures.GesturesPluginImpl::<init>(android.content.Context, android.util.AttributeSet, float, android.os.Handler, android.os.Handler)
java.method.numberOfParametersChanged: The number of parameters of the method have changed.
BINARY: BREAKING, SOURCE: BREAKING

old: method boolean com.mapbox.maps.plugin.gestures.GesturesPluginImpl::handleFlingEvent$plugin_gestures_release(android.view.MotionEvent, android.view.MotionEvent, float, float)
new: method boolean com.mapbox.maps.plugin.gestures.GesturesPluginImpl::handleFlingEvent$plugin_gestures_release(android.view.MotionEvent, float, float)
java.method.numberOfParametersChanged: The number of parameters of the method have changed.
BINARY: BREAKING, SOURCE: BREAKING

======================== sdk ========================
Analysis results
----------------

Old API: tmp.fPllR71zuI
New API: tmp.1v4qILN4bK
old: field com.mapbox.maps.renderer.MapboxWidgetRenderer.TAG
new: field com.mapbox.maps.renderer.MapboxWidgetRenderer.TAG
java.field.visibilityReduced: Visibility was reduced from 'public' to 'private'.
BINARY: BREAKING, SOURCE: BREAKING

======================== sdk-base ========================
Analysis results
----------------

Old API: tmp.9ZZe5NSaLK
New API: tmp.o1AVnbDrek
old: method com.mapbox.maps.plugin.LocationPuck2D com.mapbox.maps.plugin.LocationPuck2D::copy(android.graphics.drawable.Drawable, android.graphics.drawable.Drawable, android.graphics.drawable.Drawable, java.lang.String)
new: method com.mapbox.maps.plugin.LocationPuck2D com.mapbox.maps.plugin.LocationPuck2D::copy(android.graphics.drawable.Drawable, android.graphics.drawable.Drawable, android.graphics.drawable.Drawable, java.lang.String, float)
java.method.numberOfParametersChanged: The number of parameters of the method have changed.
BINARY: BREAKING, SOURCE: BREAKING

User impact (optional)

Pull request checklist:

  • [x] Briefly describe the changes in this PR.
  • [ ] Include before/after visuals or gifs if this PR includes visual changes.
  • [ ] Write tests for all new functionality. If tests were not written, please explain why.
  • [ ] Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • [ ] Add example if relevant.
  • [ ] Document any changes to public APIs.
  • [ ] Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • [x] Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • [x] If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

yunikkk avatar Oct 14 '22 13:10 yunikkk

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 14 '22 13:10 CLAassistant