mapbox-maps-android icon indicating copy to clipboard operation
mapbox-maps-android copied to clipboard

Migrate animations to `androidx.core.animation`

Open kmadsen opened this issue 3 years ago • 1 comments

I'm looking for what could cause an issue with AnimatorSet. And am noticing that the android.animation.AnimatorSet is not really being supported anymore.

The issues are being addressed in the androidx support libraries https://issuetracker.google.com/issues/64912778#comment4

Instead of android.animation.AndroidSet maps should use androidx.core.animation.AnimatorSet

Here are the files using import android.animation

➜  mapbox-maps-android git:(main) grep -rl 'import android.animation.' .
./app/src/main/java/com/mapbox/maps/testapp/examples/markersandcallouts/AnimatedMarkerActivity.kt
./app/src/main/java/com/mapbox/maps/testapp/examples/markersandcallouts/PointAnnotationActivity.kt
./app/src/main/java/com/mapbox/maps/testapp/examples/markersandcallouts/IconSizeChangeOnClickActivity.kt
./app/src/main/java/com/mapbox/maps/testapp/examples/linesandpolygons/MovingIconWithTrailingLineActivity.kt
./app/src/main/java/com/mapbox/maps/testapp/examples/OngoingAnimationActivity.kt
./app/src/main/java/com/mapbox/maps/testapp/examples/camera/CameraPredefinedAnimatorsActivity.kt
./app/src/main/java/com/mapbox/maps/testapp/examples/terrain3D/SantaCatalinaActivity.kt
./app/src/main/java/com/mapbox/maps/testapp/examples/annotation/AnimatePointAnnotationActivity.kt
./app/src/main/java/com/mapbox/maps/testapp/examples/TextureViewAnimateActivity.kt
./plugin-viewport/src/test/kotlin/com/mapbox/maps/plugin/viewport/transition/TransitionUtilsTest.kt
./plugin-viewport/src/test/kotlin/com/mapbox/maps/plugin/viewport/transition/DefaultViewportTransitionImplTest.kt
./plugin-viewport/src/test/kotlin/com/mapbox/maps/plugin/viewport/transition/MapboxViewportTransitionFactoryTest.kt
./plugin-viewport/src/test/kotlin/com/mapbox/maps/plugin/viewport/state/FollowPuckViewportStateImplTest.kt
./plugin-viewport/src/test/kotlin/com/mapbox/maps/plugin/viewport/state/OverviewViewportStateImplTest.kt
./plugin-viewport/src/main/kotlin/com/mapbox/maps/plugin/viewport/transition/MapboxViewportTransitionFactory.kt
./plugin-viewport/src/main/kotlin/com/mapbox/maps/plugin/viewport/transition/DefaultViewportTransitionImpl.kt
./plugin-viewport/src/main/kotlin/com/mapbox/maps/plugin/viewport/transition/TransitionUtils.kt
./plugin-viewport/src/main/kotlin/com/mapbox/maps/plugin/viewport/state/FollowPuckViewportStateImpl.kt
./plugin-viewport/src/main/kotlin/com/mapbox/maps/plugin/viewport/state/OverviewViewportStateImpl.kt
./plugin-viewport/src/main/kotlin/com/mapbox/maps/plugin/viewport/ViewportPluginImpl.kt
./plugin-compass/src/test/java/com/mapbox/maps/plugin/compass/CompassViewPluginTest.kt
./plugin-compass/src/main/java/com/mapbox/maps/plugin/compass/CompassViewPlugin.kt
./sdk-base/src/main/java/com/mapbox/maps/plugin/animation/MapAnimationOptions.kt
./sdk-base/src/main/java/com/mapbox/maps/plugin/animation/CameraAnimationsLifecycleListener.kt
./sdk-base/src/main/java/com/mapbox/maps/plugin/animation/CameraAnimationsPlugin.kt
./sdk-base/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationConsumer2.kt
./sdk-base/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationConsumer.kt
./sdk/src/androidTest/java/com/mapbox/maps/CameraAnimationsPluginTest.kt
./plugin-gestures/src/test/java/com/mapbox/maps/plugin/gestures/GesturesPluginTest.kt
./plugin-gestures/src/main/java/com/mapbox/maps/plugin/gestures/GesturesPluginImpl.kt
./plugin-animation/src/test/java/com/mapbox/maps/plugin/animation/CameraAnimatorsFactoryTest.kt
./plugin-animation/src/test/java/com/mapbox/maps/plugin/animation/CameraAnimationsListenersTest.kt
./plugin-animation/src/test/java/com/mapbox/maps/plugin/animation/CameraAnimationsPluginImplTest.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/HighLevelAnimatorSet.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/CameraAnimationsPluginImpl.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/CameraAnimatorsFactory.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/animator/CameraZoomAnimator.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/animator/CameraCenterAnimator.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/animator/CameraAnchorAnimator.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/animator/Evaluators.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/animator/CameraAnimator.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/animator/CameraBearingAnimator.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/animator/CameraPitchAnimator.kt
./plugin-animation/src/main/java/com/mapbox/maps/plugin/animation/animator/CameraPaddingAnimator.kt
./plugin-locationcomponent/src/test/java/com/mapbox/maps/plugin/locationcomponent/LocationComponentPluginImplTest.kt
./plugin-locationcomponent/src/test/java/com/mapbox/maps/plugin/locationcomponent/animators/PuckPositionAnimatorTest.kt
./plugin-locationcomponent/src/test/java/com/mapbox/maps/plugin/locationcomponent/animators/PuckPulsingAnimatorTest.kt
./plugin-locationcomponent/src/test/java/com/mapbox/maps/plugin/locationcomponent/animators/PuckAnimatorManagerTest.kt
./plugin-locationcomponent/src/test/java/com/mapbox/maps/plugin/locationcomponent/animators/PuckAccuracyRadiusAnimatorTest.kt
./plugin-locationcomponent/src/test/java/com/mapbox/maps/plugin/locationcomponent/animators/PuckBearingAnimatorTest.kt
./plugin-locationcomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationPuckManager.kt
./plugin-locationcomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/animators/PuckAnimator.kt
./plugin-locationcomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/animators/Evaluators.kt
./plugin-locationcomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/animators/PuckAnimatorManager.kt
./plugin-locationcomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationComponentPluginImpl.kt

kmadsen avatar Jun 02 '22 18:06 kmadsen

Actually.. this ticket may be "too soon". The core-animation jetpack library is in beta

https://developer.android.com/jetpack/androidx/releases/core Screen Shot 2022-06-02 at 11 49 01 AM

kmadsen avatar Jun 02 '22 18:06 kmadsen