mapbox-java icon indicating copy to clipboard operation
mapbox-java copied to clipboard

payment methods [DO-NOT-MERGE]

Open VysotskiVadim opened this issue 3 years ago • 2 comments

VysotskiVadim avatar Jun 07 '22 12:06 VysotskiVadim

Codecov Report

Merging #1449 (d8f3ab3) into main (bab9e05) will decrease coverage by 1.14%. The diff coverage is 100.00%.

:exclamation: Current head d8f3ab3 differs from pull request most recent head 526e833. Consider uploading reports for the commit 526e833 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1449      +/-   ##
============================================
- Coverage     76.90%   75.76%   -1.15%     
+ Complexity      937      883      -54     
============================================
  Files           129      125       -4     
  Lines          4019     3911     -108     
  Branches        582      578       -4     
============================================
- Hits           3091     2963     -128     
- Misses          678      686       +8     
- Partials        250      262      +12     
Impacted Files Coverage Δ
...ox/api/directions/v5/models/IntersectionLanes.java 100.00% <ø> (ø)
.../mapbox/api/directions/v5/models/RouteOptions.java 86.17% <100.00%> (-8.89%) :arrow_down:
...com/mapbox/api/directions/v5/MapboxDirections.java 89.16% <100.00%> (-0.44%) :arrow_down:
.../main/java/com/mapbox/turf/TurfTransformation.java 0.00% <0.00%> (-76.00%) :arrow_down:
.../com/mapbox/api/directions/v5/models/Metadata.java 0.00% <0.00%> (-42.86%) :arrow_down:
...om/mapbox/api/directions/v5/utils/FormatUtils.java 70.42% <0.00%> (-12.68%) :arrow_down:
...apbox/api/matching/v5/MatchingResponseFactory.java 93.87% <0.00%> (-0.13%) :arrow_down:
...n/java/com/mapbox/geojson/utils/PolylineUtils.java 78.09% <0.00%> (ø)
... and 15 more

codecov[bot] avatar Jun 07 '22 12:06 codecov[bot]

@LukasPaczos , @RingerJK , @dzinad , the PR isn't ready to be merged but it's ready for review 🙂

VysotskiVadim avatar Jun 08 '22 15:06 VysotskiVadim

Fixed the conflicts, but the feature is temporarily removed from backend. Will place the ticket in "to track" and wait for the updates (targeting next week).

dzinad avatar Nov 04 '22 15:11 dzinad

Tested it on staging. Works fine, I've adjusted some string constants. Leaving the DO NOT MERGE label until it's in production.

dzinad avatar Nov 09 '22 14:11 dzinad