queryRenderedFeatures on FillLayer with holes

[tobrun]

trafficstars

A user reached out about queryRenderedFeatures returning features when clicking on a hole of a FillLayer. I was able to reproduce this issue only on lower zoom levels. In gif below you can see it working correctly for higher zoom levels but when zooming out it breaks.

Note for this test, I was using: queryRenderedFeatures(PointF coordinates, String layerIds) to get more precise results as the default Android binding implementation that relies on RectF.

[tobrun]

Adding a proposed solution from @mb12 in #10086 (that issue was closed as duplicate):

    bool polygonIntersectsMultiPolygon(const GeometryCoordinates& polygon, const GeometryCollection& multiPolygon) {
        std::vector<GeometryCollection> actualPolygonArray = classifyRings(multiPolygon);
        for (const GeometryCollection& actualPolygon : actualPolygonArray) {
            size_t polysize = actualPolygon.size();
            if(polysize) {
                bool inside_outer_ring = polygonIntersectsPolygon(polygon, actualPolygon[0]);
                if(inside_outer_ring) {
                    //point should be inside_outer_ring and outside all inner rings
                    for(size_t holeIndex=1; holeIndex<polysize; ++holeIndex) {
                        bool inside_hole = polygonIntersectsPolygon(polygon, actualPolygon[holeIndex]);
                        if(inside_hole) {
                            return false;
                        }
                    }
                    return true;
                }
            }
        }
        return false;
    }

[stale[bot]]

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

[stale[bot]]

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

[stale[bot]]

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

[samfader]

@tobrun @kkaefer The proposed solution in https://github.com/mapbox/mapbox-gl-native/issues/9686#issuecomment-334737165 looks promising. Re-opening this ticket as I still believe this would be a helpful feature/fix.

[zugaldia]

/fyi: @tmpsantos

[stale[bot]]

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

[erinc35]

@tobrun it is not alarming for TWC's customer but they would still like to get this fixed. Any idea it could be resurfaced?