mapbox-gl-native-android icon indicating copy to clipboard operation
mapbox-gl-native-android copied to clipboard

Published 20 hours ago • verified publisher icon mapbox

Suggestion: make LocationComponentCompassEngine public

Open andrei-tofan opened this issue 4 years ago • 4 comments

In the react-native-mapbox-gl project, the heading of a user location is incorrectly reporting the course/bearing value for Android (see issue https://github.com/react-native-mapbox-gl/maps/issues/1213 for background info).

To fix this bug in react-native-mapbox-gl, we would need to get the heading value from this native Android mapbox project.

The heading is available in the LocationComponentCompassEngine class but this is private so not accessible for the react-native-mapbox-gl project to use.

It would be great if LocationComponentCompassEngine could be made public so that in react-native-mapbox-gl we could just create a new instance of LocationComponentCompassEngine. This would prevent code duplication and ensure that it stays up to date with the implementation from this project.

Let me know what your thoughts are on this.

andrei-tofan avatar Feb 23 '21 06:02 andrei-tofan

Same issue for us. Makes Android location bearing unusable in our various projects.

systemlevel avatar Feb 26 '21 14:02 systemlevel

Same here. Would be great if you could tackle this!

mzu avatar Mar 06 '21 09:03 mzu

@tobrun what are your thoughts on this?

andrei-tofan avatar Apr 21 '21 07:04 andrei-tofan

@tobrun what are your thoughts on this?

We are currently focusing on v10.0.0 development in:

  • https://github.com/mapbox/mapbox-maps-android

v9 is still being maintained and we happily expect pull request for it.

tobrun avatar Apr 21 '21 07:04 tobrun