Extra control placement 3039

[Ethan-Guttman]

This closes the good first issue #3039 (Allow controls to be placed at top-center, bottom-center, left-center, and right-center)

example pictures showcasing all four new positions:

Multiple ctrls will have margins between themselves like the already existing positions. However, depending on their widths in the top and bottom center they can look weird (smaller elements floating left).

I ordered the positions code in the css and map.js files by going from top-left to center-left clockwise listing each position too.

[CLAassistant]

All committers have signed the CLA.

[mourner]

Sorry for the late response — this PR is on our mind and we'll look at it closer after we're done with the current v3.3 release. 🙏

[Ethan-Guttman]

No problem, thanks for the update!

[rizvanovic]

This would be sick to get out

[JabSYsEmb]

It seems that no changes since last comment by @Ethan-Guttman. I can take over the issue if you're tight on time... let me know

[Ethan-Guttman]

It seems that no changes since last comment by @Ethan-Guttman. I can take over the issue if you're tight on time... let me know

I was waiting for a contact from the Mapbox team before updating again (since they said they would look at it closer later). I'll make the changes myself

[stepankuzmin]

Hey @Ethan-Guttman,

Thanks for the contribution, and I'm sorry for the delay. Is there a chance you could rebase your changes on top of the latest main? Overall, this looks good to me, so resolving the conflicts seems to be the last thing we need to do before landing this.

[Ethan-Guttman]

@stepankuzmin I'll try to rebase it by end of day today. Thanks for the go ahead!

[Ethan-Guttman]

I'm at a bit of a loss here. This is my first ticket and I have clicked the link to sign the CLA multiple times. It might just not be reflected here as it does sometimes indicate that I have signed it when I click the link. Aside from that if there is something genuinely wrong with the mac safari version I can't test it myself (having no apple devices). Those are the only failing checks

[stepankuzmin]

Hey @Ethan-Guttman,

The rebase seems wrong because your changes were made before we transitioned to TypeScript, and now your PR has 2k files changed. It'd be easier for maintainers to update your PR directly. Could you please make sure that you've enabled edits and access to secrets by maintainers on that PR?

[Ethan-Guttman]

@stepankuzmin Thank you for the help and let me know if anything else is needed

[stepankuzmin]

Thanks for the contribution, @Ethan-Guttman, merging 👍