mapbox-gl-js icon indicating copy to clipboard operation
mapbox-gl-js copied to clipboard

Upgrade to Node v18

Open stepankuzmin opened this issue 2 years ago • 8 comments

This PR upgrades mapbox-gl to Node v18.

  • [x] Use Node v18 API in node-loader
  • [x] Bump CircleCI Docker image to the latest cimg/node:18.12-browsers version

stepankuzmin avatar Oct 04 '22 10:10 stepankuzmin

Some tests fail consistently. Looking at container-diff doesn't show anything suspicious for me.

container-diff diff cimg/node:14.16-browsers cimg/node:14.20-browsers --type=history --type=apt --type=node

Output
-----Apt-----

Packages found only in cimg/node:14.16-browsers:
NAME              VERSION                         SIZE
-libllvm11        1:11.0.0-2~ubuntu20.04.1        79.3M
-vim-tiny         2:8.1.2269-1ubuntu5             1.5M

Packages found only in cimg/node:14.20-browsers:
NAME                             VERSION                          SIZE
-alsa-topology-conf              1.2.2-1                          160K
-alsa-ucm-conf                   1.2.2-1ubuntu0.13                338K
-cmake                           3.16.3-1ubuntu1                  18.3M
-cmake-data                      3.16.3-1ubuntu1                  8.3M
-docker-compose-plugin           2.6.0~ubuntu-focal               25.3M
-docker-scan-plugin              0.17.0~ubuntu-focal              12.7M
-libarchive13                    3.4.0-2ubuntu1.2                 845K
-libcanberra0                    0.30-7ubuntu1                    121K
-libcurl4-openssl-dev            7.68.0-1ubuntu2.12               1.5M
-libgpm2                         1.20.7-5                         59K
-libjsoncpp1                     1.7.4-3.1ubuntu2                 241K
-libllvm12                       1:12.0.0-3ubuntu1~20.04.5        87.3M
-libogg0                         1.3.4-0ubuntu1                   70K
-libpython3.8                    3.8.10-0ubuntu1~20.04.5          5.3M
-librhash0                       1.3.9-1                          207K
-libsqlite3-dev                  3.31.1-4ubuntu0.3                2.3M
-libssl-dev                      1.1.1f-1ubuntu2.16               7.6M
-libtdb1                         1.4.3-0ubuntu0.20.04.1           139K
-libuv1                          1.34.2-1ubuntu1.3                250K
-libvorbis0a                     1.3.6-2ubuntu1                   210K
-libvorbisfile3                  1.3.6-2ubuntu1                   63K
-postgresql-client               12 214ubuntu0.1                  66K
-postgresql-client-12            12.11-0ubuntu0.20.04.1           3.6M
-postgresql-client-common        214ubuntu0.1                     178K
-shellcheck                      0.7.0-2build2                    16.8M
-sound-theme-freedesktop         0.8-2ubuntu1                     537K
-vim                             2:8.1.2269-1ubuntu5.7            3M
-vim-runtime                     2:8.1.2269-1ubuntu5.7            30M

Version differences:
PACKAGE                             IMAGE1 (cimg/node:14.16-browsers)             IMAGE2 (cimg/node:14.20-browsers)
-apt                                2.0.4, 4.1M                                   2.0.9, 4.1M
-apt-transport-https                2.0.4, 157K                                   2.0.9, 158K
-base-files                         11ubuntu5.3, 392K                             11ubuntu5.5, 392K
-bash                               5.0-6ubuntu1.1, 1.6M                          5.0-6ubuntu1.2, 1.6M
-binutils                           2.34-6ubuntu1.1, 107K                         2.34-6ubuntu1.3, 107K
-binutils-common                    2.34-6ubuntu1.1, 424K                         2.34-6ubuntu1.3, 424K
-binutils-x86-64-linux-gnu          2.34-6ubuntu1.1, 9.6M                         2.34-6ubuntu1.3, 9.6M
-bsdutils                           1:2.34-0.1ubuntu9.1, 303K                     1:2.34-0.1ubuntu9.3, 304K
-ca-certificates                    20210119~20.04.1, 381K                        20211016~20.04.1, 375K
-containerd.io                      1.4.4-1, 124.2M                               1.6.6-1, 121.4M
-cpp-9                              9.3.0-17ubuntu1~20.04, 25.6M                  9.4.0-1ubuntu1~20.04.1, 25.6M
-curl                               7.68.0-1ubuntu2.5, 401K                       7.68.0-1ubuntu2.12, 402K
-dbus                               1.12.16-2ubuntu2.1, 618K                      1.12.16-2ubuntu2.2, 619K
-dbus-user-session                  1.12.16-2ubuntu2.1, 126K                      1.12.16-2ubuntu2.2, 127K
-dirmngr                            2.2.19-3ubuntu2.1, 918K                       2.2.19-3ubuntu2.2, 918K
-distro-info-data                   0.43ubuntu1.4, 17K                            0.43ubuntu1.10, 17K
-docker-ce                          5:20.10.5~3-0~ubuntu-focal, 115.4M            5:20.10.17~3-0~ubuntu-focal, 95.8M
-docker-ce-cli                      5:20.10.5~3-0~ubuntu-focal, 166.2M            5:20.10.17~3-0~ubuntu-focal, 152.7M
-docker-ce-rootless-extras          5:20.10.5~3-0~ubuntu-focal, 24.1M             5:20.10.17~3-0~ubuntu-focal, 19.5M
-dpkg                               1.19.7ubuntu3, 6.6M                           1.19.7ubuntu3.2, 6.6M
-dpkg-dev                           1.19.7ubuntu3, 2M                             1.19.7ubuntu3.2, 2M
-e2fsprogs                          1.45.5-2ubuntu1, 1.5M                         1.45.5-2ubuntu1.1, 1.5M
-fdisk                              2.34-0.1ubuntu9.1, 505K                       2.34-0.1ubuntu9.3, 506K
-g++-9                              9.3.0-17ubuntu1~20.04, 27.3M                  9.4.0-1ubuntu1~20.04.1, 27.4M
-gcc-10-base                        10.2.0-5ubuntu1~20.04, 260K                   10.3.0-1ubuntu1~20.04, 265K
-gcc-9                              9.3.0-17ubuntu1~20.04, 29.1M                  9.4.0-1ubuntu1~20.04.1, 29.1M
-gcc-9-base                         9.3.0-17ubuntu1~20.04, 263K                   9.4.0-1ubuntu1~20.04.1, 265K
-gir1.2-gdkpixbuf-2.0               2.40.0 dfsg-3ubuntu0.2, 46K                   2.40.0 dfsg-3ubuntu0.4, 46K
-gir1.2-gtk-3.0                     3.24.20-0ubuntu1, 1011K                       3.24.20-0ubuntu1.1, 1011K
-gir1.2-harfbuzz-0.0                2.6.4-1ubuntu4, 132K                          2.6.4-1ubuntu4.2, 133K
-git                                1:2.25.1-1ubuntu3.1, 34.8M                    1:2.37.1-0ppa1~ubuntu20.04.1, 38.3M
-git-man                            1:2.25.1-1ubuntu3.1, 1.7M                     1:2.37.1-0ppa1~ubuntu20.04.1, 2M
-gnupg                              2.2.19-3ubuntu2.1, 413K                       2.2.19-3ubuntu2.2, 413K
-gnupg-agent                        2.2.19-3ubuntu2.1, 45K                        2.2.19-3ubuntu2.2, 45K
-gnupg-l10n                         2.2.19-3ubuntu2.1, 380K                       2.2.19-3ubuntu2.2, 380K
-gnupg-utils                        2.2.19-3ubuntu2.1, 1.5M                       2.2.19-3ubuntu2.2, 1.5M
-gpg                                2.2.19-3ubuntu2.1, 1.1M                       2.2.19-3ubuntu2.2, 1.1M
-gpg-agent                          2.2.19-3ubuntu2.1, 911K                       2.2.19-3ubuntu2.2, 911K
-gpg-wks-client                     2.2.19-3ubuntu2.1, 275K                       2.2.19-3ubuntu2.2, 275K
-gpg-wks-server                     2.2.19-3ubuntu2.1, 255K                       2.2.19-3ubuntu2.2, 255K
-gpgconf                            2.2.19-3ubuntu2.1, 409K                       2.2.19-3ubuntu2.2, 409K
-gpgsm                              2.2.19-3ubuntu2.1, 568K                       2.2.19-3ubuntu2.2, 568K
-gpgv                               2.2.19-3ubuntu2.1, 499K                       2.2.19-3ubuntu2.2, 499K
-gtk-update-icon-cache              3.24.20-0ubuntu1, 154K                        3.24.20-0ubuntu1.1, 154K
-gzip                               1.10-0ubuntu4, 245K                           1.10-0ubuntu4.1, 245K
-icu-devtools                       66.1-2ubuntu2, 678K                           66.1-2ubuntu2.1, 679K
-libapt-pkg6.0                      2.0.4, 3.2M                                   2.0.9, 3.2M
-libasan5                           9.3.0-17ubuntu1~20.04, 1.6M                   9.4.0-1ubuntu1~20.04.1, 14.6M
-libasound2                         1.2.2-2.1ubuntu2.3, 1.1M                      1.2.2-2.1ubuntu2.5, 1.1M
-libasound2-data                    1.2.2-2.1ubuntu2.3, 215K                      1.2.2-2.1ubuntu2.5, 215K
-libatomic1                         10.2.0-5ubuntu1~20.04, 45K                    10.3.0-1ubuntu1~20.04, 45K
-libavahi-client3                   0.7-4ubuntu7, 129K                            0.7-4ubuntu7.1, 129K
-libavahi-common-data               0.7-4ubuntu7, 112K                            0.7-4ubuntu7.1, 112K
-libavahi-common3                   0.7-4ubuntu7, 109K                            0.7-4ubuntu7.1, 109K
-libbinutils                        2.34-6ubuntu1.1, 2.6M                         2.34-6ubuntu1.3, 2.6M
-libblkid-dev                       2.34-0.1ubuntu9.1, 933K                       2.34-0.1ubuntu9.3, 934K
-libblkid1                          2.34-0.1ubuntu9.1, 439K                       2.34-0.1ubuntu9.3, 440K
-libc-bin                           2.31-0ubuntu9.2, 3.6M                         2.31-0ubuntu9.9, 3.6M
-libc-dev-bin                       2.31-0ubuntu9.2, 441K                         2.31-0ubuntu9.9, 442K
-libc6                              2.31-0ubuntu9.2, 12.9M                        2.31-0ubuntu9.9, 12.9M
-libc6-dev                          2.31-0ubuntu9.2, 18.6M                        2.31-0ubuntu9.9, 18.6M
-libcc1-0                           10.2.0-5ubuntu1~20.04, 140K                   10.3.0-1ubuntu1~20.04, 156K
-libcom-err2                        1.45.5-2ubuntu1, 100K                         1.45.5-2ubuntu1.1, 100K
-libcryptsetup12                    2:2.2.2-3ubuntu2.3, 530K                      2:2.2.2-3ubuntu2.4, 495K
-libctf-nobfd0                      2.34-6ubuntu1.1, 197K                         2.34-6ubuntu1.3, 197K
-libctf0                            2.34-6ubuntu1.1, 130K                         2.34-6ubuntu1.3, 130K
-libcups2                           2.3.1-9ubuntu1.1, 770K                        2.3.1-9ubuntu1.2, 770K
-libcurl3-gnutls                    7.68.0-1ubuntu2.5, 684K                       7.68.0-1ubuntu2.12, 685K
-libcurl4                           7.68.0-1ubuntu2.5, 688K                       7.68.0-1ubuntu2.12, 693K
-libdbus-1-3                        1.12.16-2ubuntu2.1, 465K                      1.12.16-2ubuntu2.2, 466K
-libdbus-1-dev                      1.12.16-2ubuntu2.1, 968K                      1.12.16-2ubuntu2.2, 969K
-libdpkg-perl                       1.19.7ubuntu3, 2.1M                           1.19.7ubuntu3.2, 2.1M
-libdrm-amdgpu1                     2.4.102-1ubuntu1~20.04.1, 83K                 2.4.107-8ubuntu1~20.04.2, 84K
-libdrm-common                      2.4.102-1ubuntu1~20.04.1, 41K                 2.4.107-8ubuntu1~20.04.2, 45K
-libdrm-intel1                      2.4.102-1ubuntu1~20.04.1, 185K                2.4.107-8ubuntu1~20.04.2, 186K
-libdrm-nouveau2                    2.4.102-1ubuntu1~20.04.1, 81K                 2.4.107-8ubuntu1~20.04.2, 82K
-libdrm-radeon1                     2.4.102-1ubuntu1~20.04.1, 94K                 2.4.107-8ubuntu1~20.04.2, 95K
-libdrm2                            2.4.102-1ubuntu1~20.04.1, 119K                2.4.107-8ubuntu1~20.04.2, 128K
-libegl-dev                         1.3.2-1~ubuntu0.20.04.1, 117K                 1.3.2-1~ubuntu0.20.04.2, 117K
-libegl-mesa0                       20.2.6-0ubuntu0.20.04.1, 347K                 21.2.6-0ubuntu0.1~20.04.2, 341K
-libegl1                            1.3.2-1~ubuntu0.20.04.1, 108K                 1.3.2-1~ubuntu0.20.04.2, 108K
-libegl1-mesa-dev                   20.2.6-0ubuntu0.20.04.1, 77K                  21.2.6-0ubuntu0.1~20.04.2, 79K
-libexpat1                          2.2.9-1build1, 401K                           2.2.9-1ubuntu0.4, 402K
-libexpat1-dev                      2.2.9-1build1, 847K                           2.2.9-1ubuntu0.4, 855K
-libext2fs2                         1.45.5-2ubuntu1, 540K                         1.45.5-2ubuntu1.1, 540K
-libfdisk1                          2.34-0.1ubuntu9.1, 548K                       2.34-0.1ubuntu9.3, 549K
-libfreetype-dev                    2.10.1-2ubuntu0.1, 1.9M                       2.10.1-2ubuntu0.2, 1.9M
-libfreetype6                       2.10.1-2ubuntu0.1, 836K                       2.10.1-2ubuntu0.2, 837K
-libfreetype6-dev                   2.10.1-2ubuntu0.1, 66K                        2.10.1-2ubuntu0.2, 67K
-libfribidi-dev                     1.0.8-2, 285K                                 1.0.8-2ubuntu0.1, 285K
-libfribidi0                        1.0.8-2, 139K                                 1.0.8-2ubuntu0.1, 139K
-libgbm1                            20.2.6-0ubuntu0.20.04.1, 146K                 21.2.6-0ubuntu0.1~20.04.2, 144K
-libgcc-9-dev                       9.3.0-17ubuntu1~20.04, 13.6M                  9.4.0-1ubuntu1~20.04.1, 13.6M
-libgcc-s1                          10.2.0-5ubuntu1~20.04, 120K                   10.3.0-1ubuntu1~20.04, 120K
-libgcrypt20                        1.8.5-5ubuntu1, 1.2M                          1.8.5-5ubuntu1.1, 1.2M
-libgdk-pixbuf2.0-0                 2.40.0 dfsg-3ubuntu0.2, 620K                  2.40.0 dfsg-3ubuntu0.4, 620K
-libgdk-pixbuf2.0-bin               2.40.0 dfsg-3ubuntu0.2, 82K                   2.40.0 dfsg-3ubuntu0.4, 82K
-libgdk-pixbuf2.0-common            2.40.0 dfsg-3ubuntu0.2, 52K                   2.40.0 dfsg-3ubuntu0.4, 52K
-libgdk-pixbuf2.0-dev               2.40.0 dfsg-3ubuntu0.2, 425K                  2.40.0 dfsg-3ubuntu0.4, 425K
-libgl-dev                          1.3.2-1~ubuntu0.20.04.1, 1.3M                 1.3.2-1~ubuntu0.20.04.2, 1.3M
-libgl1                             1.3.2-1~ubuntu0.20.04.1, 657K                 1.3.2-1~ubuntu0.20.04.2, 657K
-libgl1-mesa-dev                    20.2.6-0ubuntu0.20.04.1, 68K                  21.2.6-0ubuntu0.1~20.04.2, 70K
-libgl1-mesa-dri                    20.2.6-0ubuntu0.20.04.1, 282M                 21.2.6-0ubuntu0.1~20.04.2, 379.3M
-libglapi-mesa                      20.2.6-0ubuntu0.20.04.1, 295K                 21.2.6-0ubuntu0.1~20.04.2, 305K
-libgles-dev                        1.3.2-1~ubuntu0.20.04.1, 701K                 1.3.2-1~ubuntu0.20.04.2, 701K
-libgles1                           1.3.2-1~ubuntu0.20.04.1, 74K                  1.3.2-1~ubuntu0.20.04.2, 74K
-libgles2                           1.3.2-1~ubuntu0.20.04.1, 106K                 1.3.2-1~ubuntu0.20.04.2, 106K
-libglib2.0-0                       2.64.6-1~ubuntu20.04.3, 3.9M                  2.64.6-1~ubuntu20.04.4, 3.9M
-libglib2.0-bin                     2.64.6-1~ubuntu20.04.3, 333K                  2.64.6-1~ubuntu20.04.4, 334K
-libglib2.0-data                    2.64.6-1~ubuntu20.04.3, 104K                  2.64.6-1~ubuntu20.04.4, 104K
-libglib2.0-dev                     2.64.6-1~ubuntu20.04.3, 9.6M                  2.64.6-1~ubuntu20.04.4, 9.6M
-libglib2.0-dev-bin                 2.64.6-1~ubuntu20.04.3, 630K                  2.64.6-1~ubuntu20.04.4, 631K
-libglvnd-dev                       1.3.2-1~ubuntu0.20.04.1, 65K                  1.3.2-1~ubuntu0.20.04.2, 65K
-libglvnd0                          1.3.2-1~ubuntu0.20.04.1, 725K                 1.3.2-1~ubuntu0.20.04.2, 725K
-libglx-dev                         1.3.2-1~ubuntu0.20.04.1, 89K                  1.3.2-1~ubuntu0.20.04.2, 89K
-libglx-mesa0                       20.2.6-0ubuntu0.20.04.1, 606K                 21.2.6-0ubuntu0.1~20.04.2, 587K
-libglx0                            1.3.2-1~ubuntu0.20.04.1, 163K                 1.3.2-1~ubuntu0.20.04.2, 163K
-libgnutls-dane0                    3.6.13-2ubuntu1.3, 139K                       3.6.13-2ubuntu1.6, 140K
-libgnutls-openssl27                3.6.13-2ubuntu1.3, 149K                       3.6.13-2ubuntu1.6, 150K
-libgnutls28-dev                    3.6.13-2ubuntu1.3, 4.4M                       3.6.13-2ubuntu1.6, 4.4M
-libgnutls30                        3.6.13-2ubuntu1.3, 2.1M                       3.6.13-2ubuntu1.6, 2.1M
-libgnutlsxx28                      3.6.13-2ubuntu1.3, 82K                        3.6.13-2ubuntu1.6, 82K
-libgomp1                           10.2.0-5ubuntu1~20.04, 286K                   10.3.0-1ubuntu1~20.04, 286K
-libgtk-3-0                         3.24.20-0ubuntu1, 9.6M                        3.24.20-0ubuntu1.1, 9.6M
-libgtk-3-common                    3.24.20-0ubuntu1, 420K                        3.24.20-0ubuntu1.1, 420K
-libgtk-3-dev                       3.24.20-0ubuntu1, 13.4M                       3.24.20-0ubuntu1.1, 13.4M
-libharfbuzz-dev                    2.6.4-1ubuntu4, 2.8M                          2.6.4-1ubuntu4.2, 2.8M
-libharfbuzz-gobject0               2.6.4-1ubuntu4, 131K                          2.6.4-1ubuntu4.2, 132K
-libharfbuzz-icu0                   2.6.4-1ubuntu4, 34K                           2.6.4-1ubuntu4.2, 35K
-libharfbuzz0b                      2.6.4-1ubuntu4, 1M                            2.6.4-1ubuntu4.2, 1M
-libhogweed5                        3.5.1 really3.5.1-2, 241K                     3.5.1 really3.5.1-2ubuntu0.2, 237K
-libicu-dev                         66.1-2ubuntu2, 42.6M                          66.1-2ubuntu2.1, 42.6M
-libicu66                           66.1-2ubuntu2, 32M                            66.1-2ubuntu2.1, 32M
-libitm1                            10.2.0-5ubuntu1~20.04, 115K                   10.3.0-1ubuntu1~20.04, 115K
-libjpeg-turbo8                     2.0.3-0ubuntu1.20.04.1, 558K                  2.0.3-0ubuntu1.20.04.3, 559K
-libkeyutils1                       1.6-6ubuntu1, 47K                             1.6-6ubuntu1.1, 47K
-libkmod2                           27-1ubuntu2, 134K                             27-1ubuntu2.1, 142K
-libldap-2.4-2                      2.4.49 dfsg-2ubuntu1.7, 523K                  2.4.49 dfsg-2ubuntu1.9, 523K
-libldap-common                     2.4.49 dfsg-2ubuntu1.7, 102K                  2.4.49 dfsg-2ubuntu1.9, 102K
-liblsan0                           10.2.0-5ubuntu1~20.04, 390K                   10.3.0-1ubuntu1~20.04, 3.1M
-liblz4-1                           1.9.2-2, 149K                                 1.9.2-2ubuntu0.20.04.1, 149K
-liblzma5                           5.2.4-1ubuntu1, 267K                          5.2.4-1ubuntu1.1, 267K
-libmariadb-dev                     1:10.3.25-0ubuntu0.20.04.1, 5.6M              1:10.3.34-0ubuntu0.20.04.1, 5.6M
-libmariadb-dev-compat              1:10.3.25-0ubuntu0.20.04.1, 79K               1:10.3.34-0ubuntu0.20.04.1, 80K
-libmariadb3                        1:10.3.25-0ubuntu0.20.04.1, 525K              1:10.3.34-0ubuntu0.20.04.1, 541K
-libmount-dev                       2.34-0.1ubuntu9.1, 926K                       2.34-0.1ubuntu9.3, 928K
-libmount1                          2.34-0.1ubuntu9.1, 481K                       2.34-0.1ubuntu9.3, 482K
-libnettle7                         3.5.1 really3.5.1-2, 395K                     3.5.1 really3.5.1-2ubuntu0.2, 396K
-libnss-systemd                     245.4-4ubuntu3.5, 399K                        245.4-4ubuntu3.17, 404K
-libnss3                            2:3.49.1-1ubuntu1.5, 3.9M                     2:3.49.1-1ubuntu1.8, 3.9M
-libopengl-dev                      1.3.2-1~ubuntu0.20.04.1, 22K                  1.3.2-1~ubuntu0.20.04.2, 22K
-libopengl0                         1.3.2-1~ubuntu0.20.04.1, 220K                 1.3.2-1~ubuntu0.20.04.2, 220K
-libpam-modules                     1.3.1-5ubuntu4.1, 1.1M                        1.3.1-5ubuntu4.3, 1.1M
-libpam-modules-bin                 1.3.1-5ubuntu4.1, 322K                        1.3.1-5ubuntu4.3, 339K
-libpam-runtime                     1.3.1-5ubuntu4.1, 304K                        1.3.1-5ubuntu4.3, 304K
-libpam-systemd                     245.4-4ubuntu3.5, 627K                        245.4-4ubuntu3.17, 632K
-libpam0g                           1.3.1-5ubuntu4.1, 231K                        1.3.1-5ubuntu4.3, 231K
-libpcre16-3                        2:8.39-12build1, 543K                         2:8.39-12ubuntu0.1, 543K
-libpcre2-16-0                      10.34-7, 539K                                 10.34-7ubuntu0.1, 543K
-libpcre2-32-0                      10.34-7, 507K                                 10.34-7ubuntu0.1, 511K
-libpcre2-8-0                       10.34-7, 592K                                 10.34-7ubuntu0.1, 596K
-libpcre2-dev                       10.34-7, 2.4M                                 10.34-7ubuntu0.1, 2.4M
-libpcre2-posix2                    10.34-7, 33K                                  10.34-7ubuntu0.1, 33K
-libpcre3                           2:8.39-12build1, 671K                         2:8.39-12ubuntu0.1, 671K
-libpcre3-dev                       2:8.39-12build1, 2.2M                         2:8.39-12ubuntu0.1, 2.2M
-libpcre32-3                        2:8.39-12build1, 523K                         2:8.39-12ubuntu0.1, 523K
-libpcrecpp0v5                      2:8.39-12build1, 194K                         2:8.39-12ubuntu0.1, 194K
-libpolkit-agent-1-0                0.105-26ubuntu1, 78K                          0.105-26ubuntu1.3, 79K
-libpolkit-gobject-1-0              0.105-26ubuntu1, 156K                         0.105-26ubuntu1.3, 157K
-libpq-dev                          12.6-0ubuntu0.20.04.1, 572K                   12.11-0ubuntu0.20.04.1, 576K
-libpq5                             12.6-0ubuntu0.20.04.1, 400K                   12.11-0ubuntu0.20.04.1, 400K
-libprocps8                         2:3.3.16-1ubuntu2, 128K                       2:3.3.16-1ubuntu2.3, 128K
-libpython3.8-minimal               3.8.5-1~20.04.2, 4.7M                         3.8.10-0ubuntu1~20.04.5, 4.7M
-libpython3.8-stdlib                3.8.5-1~20.04.2, 7.7M                         3.8.10-0ubuntu1~20.04.5, 7.7M
-libquadmath0                       10.2.0-5ubuntu1~20.04, 304K                   10.3.0-1ubuntu1~20.04, 304K
-libsasl2-2                         2.1.27 dfsg-2, 152K                           2.1.27 dfsg-2ubuntu0.1, 152K
-libsasl2-modules                   2.1.27 dfsg-2, 236K                           2.1.27 dfsg-2ubuntu0.1, 236K
-libsasl2-modules-db                2.1.27 dfsg-2, 66K                            2.1.27 dfsg-2ubuntu0.1, 66K
-libseccomp2                        2.4.3-1ubuntu3.20.04.3, 348K                  2.5.1-1ubuntu1~20.04.2, 152K
-libsensors-config                  1:3.6.0-2ubuntu1, 42K                         1:3.6.0-2ubuntu1.1, 42K
-libsensors5                        1:3.6.0-2ubuntu1, 100K                        1:3.6.0-2ubuntu1.1, 100K
-libsepol1                          3.0-1, 738K                                   3.0-1ubuntu0.1, 734K
-libsepol1-dev                      3.0-1, 1.7M                                   3.0-1ubuntu0.1, 1.7M
-libsmartcols1                      2.34-0.1ubuntu9.1, 337K                       2.34-0.1ubuntu9.3, 338K
-libsqlite3-0                       3.31.1-4ubuntu0.2, 1.3M                       3.31.1-4ubuntu0.3, 1.3M
-libss2                             1.45.5-2ubuntu1, 108K                         1.45.5-2ubuntu1.1, 108K
-libssh-4                           0.9.3-2ubuntu2.1, 490K                        0.9.3-2ubuntu2.2, 491K
-libssl1.1                          1.1.1f-1ubuntu2.3, 3.9M                       1.1.1f-1ubuntu2.16, 3.9M
-libstdc++-9-dev                    9.3.0-17ubuntu1~20.04, 17.2M                  9.4.0-1ubuntu1~20.04.1, 17.2M
-libstdc++6                         10.2.0-5ubuntu1~20.04, 2.4M                   10.3.0-1ubuntu1~20.04, 2.4M
-libsystemd0                        245.4-4ubuntu3.5, 872K                        245.4-4ubuntu3.17, 877K
-libtiff5                           4.1.0 git191117-2ubuntu0.20.04.1, 552K        4.1.0 git191117-2ubuntu0.20.04.5, 553K
-libtsan0                           10.2.0-5ubuntu1~20.04, 1.2M                   10.3.0-1ubuntu1~20.04, 8.8M
-libubsan1                          10.2.0-5ubuntu1~20.04, 378K                   10.3.0-1ubuntu1~20.04, 2.9M
-libudev1                           245.4-4ubuntu3.5, 334K                        245.4-4ubuntu3.17, 339K
-libunbound8                        1.9.4-2ubuntu1.1, 963K                        1.9.4-2ubuntu1.2, 964K
-libuuid1                           2.34-0.1ubuntu9.1, 122K                       2.34-0.1ubuntu9.3, 123K
-libwayland-bin                     1.18.0-1, 68K                                 1.18.0-1ubuntu0.1, 69K
-libwayland-client0                 1.18.0-1, 84K                                 1.18.0-1ubuntu0.1, 85K
-libwayland-cursor0                 1.18.0-1, 57K                                 1.18.0-1ubuntu0.1, 58K
-libwayland-dev                     1.18.0-1, 545K                                1.18.0-1ubuntu0.1, 546K
-libwayland-egl1                    1.18.0-1, 33K                                 1.18.0-1ubuntu0.1, 34K
-libwayland-server0                 1.18.0-1, 106K                                1.18.0-1ubuntu0.1, 107K
-libwebp6                           0.6.1-2, 430K                                 0.6.1-2ubuntu0.20.04.1, 430K
-libx11-6                           2:1.6.9-2ubuntu1.1, 1.3M                      2:1.6.9-2ubuntu1.2, 1.3M
-libx11-data                        2:1.6.9-2ubuntu1.1, 1.5M                      2:1.6.9-2ubuntu1.2, 1.5M
-libx11-dev                         2:1.6.9-2ubuntu1.1, 2.5M                      2:1.6.9-2ubuntu1.2, 2.5M
-libx11-xcb1                        2:1.6.9-2ubuntu1.1, 84K                       2:1.6.9-2ubuntu1.2, 84K
-libxml2                            2.9.10 dfsg-5, 1.9M                           2.9.10 dfsg-5ubuntu0.20.04.3, 1.9M
-linux-libc-dev                     5.4.0-70.78, 5.8M                             5.4.0-122.138, 5.9M
-locales                            2.31-0ubuntu9.2, 16.8M                        2.31-0ubuntu9.9, 16.8M
-login                              1:4.8.1-1ubuntu5.20.04, 932K                  1:4.8.1-1ubuntu5.20.04.2, 932K
-logsave                            1.45.5-2ubuntu1, 92K                          1.45.5-2ubuntu1.1, 92K
-mariadb-common                     1:10.3.25-0ubuntu0.20.04.1, 75K               1:10.3.34-0ubuntu0.20.04.1, 76K
-mount                              2.34-0.1ubuntu9.1, 433K                       2.34-0.1ubuntu9.3, 434K
-nettle-dev                         3.5.1 really3.5.1-2, 2.5M                     3.5.1 really3.5.1-2ubuntu0.2, 2.5M
-networkd-dispatcher                2.0.1-1, 66K                                  2.1-2~ubuntu20.04.3, 69K
-openjdk-11-jre                     11.0.10 9-0ubuntu1~20.04, 116K                11.0.16 8-0ubuntu1~20.04, 527K
-openjdk-11-jre-headless            11.0.10 9-0ubuntu1~20.04, 163.1M              11.0.16 8-0ubuntu1~20.04, 163.3M
-openssh-client                     1:8.2p1-4ubuntu0.2, 4M                        1:8.2p1-4ubuntu0.5, 4M
-openssl                            1.1.1f-1ubuntu2.3, 1.2M                       1.1.1f-1ubuntu2.16, 1.2M
-passwd                             1:4.8.1-1ubuntu5.20.04, 2.6M                  1:4.8.1-1ubuntu5.20.04.2, 2.6M
-policykit-1                        0.105-26ubuntu1, 556K                         0.105-26ubuntu1.3, 560K
-procps                             2:3.3.16-1ubuntu2, 816K                       2:3.3.16-1ubuntu2.3, 816K
-python-apt-common                  2.0.0ubuntu0.20.04.4, 272K                    2.0.0ubuntu0.20.04.7, 268K
-python3-apt                        2.0.0ubuntu0.20.04.4, 715K                    2.0.0ubuntu0.20.04.7, 715K
-python3-distutils                  3.8.5-1~20.04.1, 1.3M                         3.8.10-0ubuntu1~20.04, 1.3M
-python3-lib2to3                    3.8.5-1~20.04.1, 697K                         3.8.10-0ubuntu1~20.04, 702K
-python3-software-properties        0.98.9.4, 148K                                0.99.9.8, 148K
-python3.8                          3.8.5-1~20.04.2, 496K                         3.8.10-0ubuntu1~20.04.5, 509K
-python3.8-minimal                  3.8.5-1~20.04.2, 5.4M                         3.8.10-0ubuntu1~20.04.5, 5.4M
-software-properties-common         0.98.9.4, 196K                                0.99.9.8, 196K
-sysstat                            12.2.0-2, 1.5M                                12.2.0-2ubuntu0.1, 1.4M
-systemd                            245.4-4ubuntu3.5, 14.9M                       245.4-4ubuntu3.17, 15M
-systemd-sysv                       245.4-4ubuntu3.5, 172K                        245.4-4ubuntu3.17, 177K
-systemd-timesyncd                  245.4-4ubuntu3.5, 239K                        245.4-4ubuntu3.17, 244K
-tar                                1.30 dfsg-7ubuntu0.20.04.1, 880K              1.30 dfsg-7ubuntu0.20.04.2, 880K
-tzdata                             2021a-0ubuntu0.20.04, 3.8M                    2022a-0ubuntu0.20.04, 3.8M
-ubuntu-keyring                     2020.02.11.2, 46K                             2020.02.11.4, 46K
-unattended-upgrades                2.3ubuntu0.1, 440K                            2.3ubuntu0.3, 440K
-util-linux                         2.34-0.1ubuntu9.1, 4.4M                       2.34-0.1ubuntu9.3, 4.4M
-uuid-dev                           2.34-0.1ubuntu9.1, 167K                       2.34-0.1ubuntu9.3, 168K
-vim-common                         2:8.1.2269-1ubuntu5, 375K                     2:8.1.2269-1ubuntu5.7, 376K
-wget                               1.20.3-1ubuntu1, 992K                         1.20.3-1ubuntu2, 988K
-xserver-common                     2:1.20.9-2ubuntu1.2~20.04.1, 239K             2:1.20.13-1ubuntu1~20.04.3, 240K
-xvfb                               2:1.20.9-2ubuntu1.2~20.04.1, 2.2M             2:1.20.13-1ubuntu1~20.04.3, 2.2M
-xxd                                2:8.1.2269-1ubuntu5, 201K                     2:8.1.2269-1ubuntu5.7, 202K
-xz-utils                           5.2.4-1ubuntu1, 348K                          5.2.4-1ubuntu1.1, 348K
-zlib1g                             1:1.2.11.dfsg-2ubuntu1.2, 163K                1:1.2.11.dfsg-2ubuntu1.3, 163K
-zlib1g-dev                         1:1.2.11.dfsg-2ubuntu1.2, 591K                1:1.2.11.dfsg-2ubuntu1.3, 592K


-----History-----

Docker history lines found only in cimg/node:14.16-browsers:
-/bin/sh -c #(nop) ADD file:a8d2f02fbaddf8cec8e4da320cd03c06435f395e9d454f69954efe422eb6e1ba in /
-/bin/sh -c set -xe                 && echo '#!/bin/sh' > /usr/sbin/policy-rc.d         && echo 'exit 101' >> /usr/sbin/policy-rc.d         && chmod +x /usr/sbin/policy-rc.d                 && dpkg-divert --local --rename --add /sbin/initctl         && cp -a /usr/sbin/policy-rc.d /sbin/initctl         && sed -i 's/^exit.*/exit 0/' /sbin/initctl                 && echo 'force-unsafe-io' > /etc/dpkg/dpkg.cfg.d/docker-apt-speedup                 && echo 'DPkg::Post-Invoke { "rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true"; };' > /etc/apt/apt.conf.d/docker-clean         && echo 'APT::Update::Post-Invoke { "rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true"; };' >> /etc/apt/apt.conf.d/docker-clean         && echo 'Dir::Cache::pkgcache ""; Dir::Cache::srcpkgcache "";' >> /etc/apt/apt.conf.d/docker-clean                 && echo 'Acquire::Languages "none";' > /etc/apt/apt.conf.d/docker-no-languages                 && echo 'Acquire::GzipIndexes "true"; Acquire::CompressionTypes::Order:: "gz";' > /etc/apt/apt.conf.d/docker-gzip-indexes                 && echo 'Apt::AutoRemove::SuggestsImportant "false";' > /etc/apt/apt.conf.d/docker-autoremove-suggests
-/bin/sh -c [ -z "$(apt-get indextargets)" ]
-/bin/sh -c mkdir -p /run/systemd && echo 'docker' > /run/systemd/container
-/bin/sh -c #(nop)  CMD ["/bin/bash"]
-/bin/bash -exo pipefail -c #(nop)  ENV DEBIAN_FRONTEND=noninteractive
-/bin/bash -exo pipefail -c echo 'APT::Get::Assume-Yes "true";' > /etc/apt/apt.conf.d/90circleci &&         echo 'DPkg::Options "--force-confnew";' >> /etc/apt/apt.conf.d/90circleci &&         apt-get update && apt-get install -y                 curl                            locales                         sudo         &&         locale-gen en_US.UTF-8 &&         rm -rf /var/lib/apt/lists/* &&         useradd --uid=3434 --user-group --create-home circleci &&         echo 'circleci ALL=NOPASSWD: ALL' >> /etc/sudoers.d/50-circleci &&         echo 'Defaults    env_keep += "DEBIAN_FRONTEND"' >> /etc/sudoers.d/env_keep &&         sudo -u circleci mkdir /home/circleci/project &&         curl -sSL --fail --retry 3 --output /tmp/dockerize-linux-amd64.tar.gz "https://circle-downloads.s3.amazonaws.com/circleci-images/cache/linux-amd64/dockerize-latest.tar.gz" &&         tar -C /usr/local/bin -xzvf /tmp/dockerize-linux-amd64.tar.gz &&         rm -rf /tmp/dockerize-linux-amd64.tar.gz &&         dockerize --version
-/bin/bash -exo pipefail -c apt-get update && apt-get install -y                                                                                                                                 autoconf                                             build-essential                 ca-certificates                 curl                    git                                                                      gnupg                                                                                                                                        gzip                                                                                                                                            jq                                                                                                                                                                                                                                                              libmariadb-dev                                              libmariadb-dev-compat                 libpq-dev                 make                 nano                 net-tools                 netcat                 openssh-client                 parallel                 pkg-config                 software-properties-common                 sudo                 tar                 tzdata                 unzip                 vim-tiny                 wget                 zip &&         rm -rf /var/lib/apt/lists/*
-/bin/bash -exo pipefail -c #(nop)  ENV DOCKER_VERSION=5:20.10.5~3-0~ubuntu-
-/bin/bash -exo pipefail -c apt-get update && apt-get install -y                 apt-transport-https                 ca-certificates                 curl                 gnupg-agent                 software-properties-common &&         curl -fsSL https://download.docker.com/linux/ubuntu/gpg | apt-key add - &&         add-apt-repository -y "deb [arch=amd64] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" &&         apt-get install -y docker-ce=${DOCKER_VERSION}$(lsb_release -cs) docker-ce-cli=${DOCKER_VERSION}$(lsb_release -cs) containerd.io &&         docker --version &&         rm -rf /var/lib/apt/lists/*
-/bin/bash -exo pipefail -c #(nop)  ENV COMPOSE_VERSION=1.28.6
-/bin/bash -exo pipefail -c curl -L "https://github.com/docker/compose/releases/download/${COMPOSE_VERSION}/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose &&         chmod +x /usr/local/bin/docker-compose &&         docker-compose version
-/bin/bash -exo pipefail -c #(nop)  ENV NODE_VERSION=14.16.1
-/bin/bash -exo pipefail -c #(nop)  ENV YARN_VERSION=1.22.10


Docker history lines found only in cimg/node:14.20-browsers:
-/bin/sh -c #(nop) ADD file:af4cf77e6818016b697a1491101b40c71d06529ced65f36107749f099d6d4bdc in /
-/bin/sh -c #(nop)  CMD ["bash"]
-/bin/bash -exo pipefail -c #(nop)  ENV DEBIAN_FRONTEND=noninteractive TERM=dumb PAGER=cat
-/bin/bash -exo pipefail -c echo 'APT::Get::Assume-Yes "true";' > /etc/apt/apt.conf.d/90circleci &&         echo 'DPkg::Options "--force-confnew";' >> /etc/apt/apt.conf.d/90circleci &&         apt-get update && apt-get install -y                                                                curl                                                                            locales                          sudo         &&                      locale-gen en_US.UTF-8 &&         rm -rf /var/lib/apt/lists/* &&         useradd --uid=3434 --user-group --create-home circleci &&         echo 'circleci ALL=NOPASSWD: ALL' >> /etc/sudoers.d/50-circleci &&         echo 'Defaults    env_keep += "DEBIAN_FRONTEND"' >> /etc/sudoers.d/env_keep &&         sudo -u circleci mkdir /home/circleci/project &&         sudo -u circleci mkdir /home/circleci/bin &&         curl -sSL --fail --retry 3 --output /tmp/dockerize-linux-amd64.tar.gz "https://circle-downloads.s3.amazonaws.com/circleci-images/cache/linux-amd64/dockerize-latest.tar.gz" &&         tar -C /usr/local/bin -xzvf /tmp/dockerize-linux-amd64.tar.gz &&         rm -rf /tmp/dockerize-linux-amd64.tar.gz &&         dockerize --version
-/bin/bash -exo pipefail -c noInstallRecommends="" &&                                                       if [[ "20.04" == "22.04" ]]; then                                                                                                 noInstallRecommends="--no-install-recommends";         fi &&         apt-get update && apt-get install -y $noInstallRecommends                         autoconf                      build-essential                                           ca-certificates                                                                                          cmake                                                                                                                                                             curl                                                                                                          gnupg                                                                                                                                                                                                                                                           gzip                                                        jq                 libcurl4-openssl-dev                 libmariadb-dev                 libmariadb-dev-compat                 libpq-dev                 libssl-dev                 libsqlite3-dev                 make                 nano                 net-tools                 netcat                 openssh-client                 parallel                 pkg-config                 postgresql-client                 shellcheck                 software-properties-common                 sudo                 tar                 tzdata                 unzip                 vim                 wget                 zip &&         add-apt-repository ppa:git-core/ppa && apt-get install -y git &&         rm -rf /var/lib/apt/lists/*
-/bin/bash -exo pipefail -c #(nop)  ENV DOCKER_VERSION=5:20.10.17~3-0~ubuntu-
-/bin/bash -exo pipefail -c apt-get update && apt-get install -y                 apt-transport-https                 ca-certificates                 curl                 gnupg-agent                 software-properties-common &&         curl -fsSL https://download.docker.com/linux/ubuntu/gpg | apt-key add - &&         add-apt-repository -y "deb [arch=amd64] https://download.docker.com/linux/ubuntu $( lsb_release -cs ) stable" &&         apt-get install -y docker-ce=${DOCKER_VERSION}$( lsb_release -cs ) docker-ce-cli=${DOCKER_VERSION}$( lsb_release -cs ) containerd.io &&         docker --version &&         rm -rf /var/lib/apt/lists/*
-/bin/bash -exo pipefail -c #(nop)  ENV COMPOSE_VER=2.6.0
-/bin/bash -exo pipefail -c #(nop)  ENV COMPOSE_SWITCH_VERSION=1.0.4
-/bin/bash -exo pipefail -c apt-get update && apt-get install --yes --no-install-recommends                                                                            docker-compose-plugin=${COMPOSE_VER}~ubuntu-$( lsb_release -cs )         &&         curl -fL https://github.com/docker/compose-switch/releases/download/v${COMPOSE_SWITCH_VERSION}/docker-compose-linux-amd64 -o /usr/local/bin/compose-switch &&         docker compose version &&         chmod +x /usr/local/bin/compose-switch &&         update-alternatives --install /usr/local/bin/docker-compose docker-compose /usr/local/bin/compose-switch 99 &&         docker-compose version
-/bin/bash -exo pipefail -c curl -sSL "https://github.com/mikefarah/yq/releases/download/v4.23.1/yq_linux_amd64.tar.gz" |         tar -xz -C /usr/local/bin &&         mv /usr/local/bin/yq{_linux_amd64,}
-/bin/bash -exo pipefail -c whoami &&                                                                                             git config --global --add safe.directory '*'
-/bin/bash -exo pipefail -c #(nop)  ENV NODE_VERSION=14.20.1
-/bin/bash -exo pipefail -c #(nop)  ENV PATH=/home/circleci/.yarn/bin:/home/circleci/bin:/home/circleci/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
-/bin/bash -exo pipefail -c #(nop)  ENV YARN_VERSION=1.22.18
-/bin/bash -exo pipefail -c sudo npm install -g pnpm


-----Node-----

Packages found only in cimg/node:14.16-browsers: None

Packages found only in cimg/node:14.20-browsers:
NAME             VERSION        SIZE
-corepack        0.10.0         556.1K
-pnpm            7.12.2         11.8M

Version differences:
PACKAGE        IMAGE1 (cimg/node:14.16-browsers)        IMAGE2 (cimg/node:14.20-browsers)
-npm           6.14.12, 20.3M                           6.14.17, 20.2M

stepankuzmin avatar Oct 04 '22 12:10 stepankuzmin

Most likely, it's some Docker image dependencies issue since render tests run without errors if I upgrade the node version to v14.20.1 in the cimg/node:14.16-browsers image. Google Chrome version is 106.0.5249.91 in both environments since we install it separately.

stepankuzmin avatar Oct 04 '22 13:10 stepankuzmin

Also, the test diffs are pretty minimal https://output.circle-artifacts.com/output/job/54c779f1-5ac2-42ff-8d2d-9542b197cb54/artifacts/0/test/integration/render-tests/index.html

Screen Shot 2022-10-04 at 16 17 52

However, stars' rasterization looks different

Screen Shot 2022-10-04 at 16 18 59

stepankuzmin avatar Oct 04 '22 13:10 stepankuzmin

I think that the first change isn't an issue and can be fixed with a higher "allowed" value, however different stars on local vs. CI would add a considerable burden to working with globe tests.

Looking at the other software versions with this change I see a major upgrade to docker-compose (1.28.6 to v2.6.0) and a patch to ubuntu (20.04.2 to 20.04.4), I wonder if one of these could be responsible?

cc @karimnaaji

SnailBones avatar Oct 04 '22 23:10 SnailBones

I think that the first change isn't an issue and can be fixed with a higher "allowed" value, however different stars on local vs. CI would add a considerable burden to working with globe tests.

Agree! We'd need to investigate the different stars on local vs. CI

Looking at the other software versions with this change I see a major upgrade to docker-compose (1.28.6 to v2.6.0) and a patch to ubuntu (20.04.2 to 20.04.4), I wonder if one of these could be responsible?

I don't think that either docker-compose or ubuntu patch update might be responsible for this 🤔

stepankuzmin avatar Oct 05 '22 10:10 stepankuzmin

After some debugging, it appears that the render tests start failing after upgrading the libgbm1 package which also updates the libglx-mesa0 package — an OSS implementation of the OpenGL API - GLX vendor library.

sudo apt-get --only-upgrade --dry-run install libglx-mesa0
Output
The following additional packages will be installed:
  libdrm-amdgpu1 libegl-mesa0 libgbm1 libgl1-mesa-dri libglapi-mesa

The following packages will be upgraded:
  libdrm-amdgpu1 libegl-mesa0 libgbm1 libgl1-mesa-dri libglapi-mesa libglx-mesa0
6 upgraded, 0 newly installed, 0 to remove and 245 not upgraded.

Inst libdrm-amdgpu1 [2.4.102-1ubuntu1~20.04.1] (2.4.107-8ubuntu1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64])
Inst libegl-mesa0 [20.2.6-0ubuntu0.20.04.1] (21.2.6-0ubuntu0.1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64]) []
Inst libgbm1 [20.2.6-0ubuntu0.20.04.1] (21.2.6-0ubuntu0.1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64]) []
Inst libgl1-mesa-dri [20.2.6-0ubuntu0.20.04.1] (21.2.6-0ubuntu0.1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64]) []
Inst libglx-mesa0 [20.2.6-0ubuntu0.20.04.1] (21.2.6-0ubuntu0.1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64]) []
Inst libglapi-mesa [20.2.6-0ubuntu0.20.04.1] (21.2.6-0ubuntu0.1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64])
Conf libdrm-amdgpu1 (2.4.107-8ubuntu1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64])
Conf libegl-mesa0 (21.2.6-0ubuntu0.1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64])
Conf libgbm1 (21.2.6-0ubuntu0.1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64])
Conf libgl1-mesa-dri (21.2.6-0ubuntu0.1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64])
Conf libglx-mesa0 (21.2.6-0ubuntu0.1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64])
Conf libglapi-mesa (21.2.6-0ubuntu0.1~20.04.2 Ubuntu:20.04/focal-updates, Ubuntu:20.04/focal-security [amd64])

stepankuzmin avatar Oct 06 '22 09:10 stepankuzmin

If we switch back to swiftshader from llvmpipe wich was introduced in #10389 it appears to be working, but the other tests start failing.

stepankuzmin avatar Oct 06 '22 09:10 stepankuzmin

Cross-posting some notes after debugging the upgrade to node v14.21.0 from https://github.com/mapbox/mapbox-gl-js/pull/12268#issuecomment-1330771608

Upgraded Docker image cimg/node:14.21-browsers has a new version of the libglx-mesa0 package (https://github.com/mapbox/mapbox-gl-js/pull/12277#issuecomment-1269683691), which seems to be the cause of broken image rasterization (54 tests failed, see use-gl-desktop-ignore-gpu-blocklist.html).

Screen Shot 2022-11-29 at 16 42 26

I've tried different combinations of Chrome flags, including enabling VaAPI, but it won't help.

Flags
--ignore-gpu-blocklist --use-gl=desktop
--ignore-gpu-blocklist --use-gl=egl
--ignore-gpu-blocklist --use-gl=desktop --enable-gpu-rasterization
--ignore-gpu-blocklist --use-gl=desktop --enable-features=VaapiVideoDecoder
--ignore-gpu-blocklist --use-gl=desktop MESA_GLSL_CACHE_DISABLE=false

We can fix the rasterization issue by removing the --ignore-gpu-blocklist and --use-gl=desktop args (i.e. switch back to swiftshader from llvmpipe, which was introduced in https://github.com/mapbox/mapbox-gl-js/pull/10389). It can be also achieved by enabling swiftshader ANGLE with --use-angle=swiftshader.

However, removing these args breaks icon resampling (23 tests failed, see no-desktop-and-ignore-gpu-blocklist.html). See also https://github.com/mapbox/mapbox-gl-js/issues/7331#issuecomment-1295485540

Screen Shot 2022-11-29 at 16 45 11

stepankuzmin avatar Nov 30 '22 14:11 stepankuzmin

I see the same issue with Firefox after upgrading to the cimg/node:14.21-browsers image. I've tried setting the LIBGL_ALWAYS_SOFTWARE env here, but it didn't work.

Screenshot 2023-02-10 at 17 42 05

Chrome, however, works fine.

stepankuzmin avatar Feb 10 '23 15:02 stepankuzmin

The rasterization issue might be related to this change in Mesa. From Mesa 21.0.0 Release Notes:

LIBGL_ALWAYS_SOFTWARE=1 picks zink over actual software rasterizers

See also this discussion https://gitlab.freedesktop.org/mesa/mesa/-/issues/4171

Debug info
sudo apt-get install mesa-utils
glxinfo -B

name of display: :99
display: :99  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: Mesa/X.org (0xffffffff)
    Device: llvmpipe (LLVM 15.0.6, 256 bits) (0xffffffff)
    Version: 22.2.5
    Accelerated: no
    Video memory: 70225MB
    Unified memory: no
    Preferred profile: core (0x1)
    Max core profile version: 4.5
    Max compat profile version: 4.5
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
OpenGL vendor string: Mesa/X.org
OpenGL renderer string: llvmpipe (LLVM 15.0.6, 256 bits)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 22.2.5
OpenGL core profile shading language version string: 4.50
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile

OpenGL version string: 4.5 (Compatibility Profile) Mesa 22.2.5
OpenGL shading language version string: 4.50
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile

OpenGL ES profile version string: OpenGL ES 3.2 Mesa 22.2.5
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

We can try downgrading mesa with sudo apt-get install --allow-downgrades libglapi-mesa=22.0.1-1ubuntu2

stepankuzmin avatar Feb 13 '23 13:02 stepankuzmin

Unit tests are failing with Node v18 because they hang up on the onmessage assignment during the ThrottledInvoker (https://github.com/mapbox/mapbox-gl-js/pull/8673) initialization.

https://github.com/mapbox/mapbox-gl-js/blob/ed8d8023cdfc2036bdec509c9eb933cb5d7572ed/src/util/throttled_invoker.js#L19-L22

However, if you load the ThrottledInvoker class in Node v18 CLI, it works fine

$ node --experimental-loader ./build/node-loader.js

> const ThrottledInvoker = (await import('./src/util/throttled_invoker.js')).default;
> const t = new ThrottledInvoker(() => console.log('callback'));
> t.trigger();
callback

stepankuzmin avatar May 10 '23 16:05 stepankuzmin

Found a similar issue https://github.com/facebook/react/issues/20756. Since node.js 15, there is now a global MessageChannel object, which prevents the node event loop from exiting. As a temporary fix, we can disable the MessageChannel in the unit tests globally.

stepankuzmin avatar May 11 '23 14:05 stepankuzmin

There is some issue with the CodeBuild worker cannot log into the NPM registry, I will look into it separately.

stepankuzmin avatar May 15 '23 12:05 stepankuzmin