mapbox-gl-js icon indicating copy to clipboard operation
mapbox-gl-js copied to clipboard

Published 20 hours ago • verified publisher icon mapbox

Draping artifacts on ocean tiles

Open SnailBones opened this issue 2 years ago • 7 comments

With globe or terrain enabled, trianglular artifacts appear in specific locations between zoom levels 5 and six. This occurs with the tile 5/27/14.

  1. Go to http://localhost:9966/debug/projections.html#5.5/19/125
  2. Enable globe OR terrain.

image

Acceptance Criteria:

These artifacts should no longer appear and be verified with a render test.

SnailBones avatar Jun 09 '22 19:06 SnailBones

This bug can also be seen above Alaska on tile 5/2/6, which can be viewed with http://localhost:9966/debug/projections.html#5.41/71.852/-153.459/-28/59.

image

Both of these cases are tiles with some land in the SW quadrant and are otherwise ocean.

This probably occurs in more tiles in other (especially higher) zoom levels. I've noticed these in zoom 5 as I'm working on an unrelated globe-to-Mercator transition bug.

SnailBones avatar Jun 09 '22 21:06 SnailBones

This is also occurring off the US southeast coast on tile 5/9/13 image

SnailBones avatar Jul 11 '22 21:07 SnailBones

@SnailBones are you still able to reproduce this? I tried but couldn't on all the examples above. I wonder if this is something environment-specific that's not reproducible on my machine/browser, or if it was a bug on the Streets data side that got hot-patched.

mourner avatar Jul 28 '22 13:07 mourner

@mourner Yes, just tested again and I'm still seeing this bug. I'm seeing it in Chrome, Safari, and Firefox on MacOS (Intel chip), Windows and Linux machines.

SnailBones avatar Jul 28 '22 16:07 SnailBones

@SnailBones that's so weird! Will have to unassign myself for now since I can't manage to reproduce...

mourner avatar Jul 28 '22 18:07 mourner

I also couldn't reproduce this in Chrome, Safari, and Firefox on macOS (Apple chip) with globe or terrain.

stepankuzmin avatar Aug 22 '22 12:08 stepankuzmin

Reopening, refer https://github.com/mapbox/mapbox-gl-js/pull/12203#issuecomment-1233307545

karimnaaji avatar Aug 31 '22 18:08 karimnaaji

@SnailBones, could you please try reproducing this in that jsfiddle? https://jsfiddle.net/StepanKuzmin/4psda2o8/8/

stepankuzmin avatar Sep 27 '22 12:09 stepankuzmin

@stepankuzmin Thanks for the nice reproduction! I'm able to reproduce it in all three locations with your jsfiddle.

SnailBones avatar Sep 27 '22 14:09 SnailBones

Taking a stab at this issue as I can reproduce it consistently (macbook pro, monterey 12.6, intel processor). I checked out the previous fix that was reverted: #12203 which resolves the issue on my machine. Does this solution still make the issue appear for you @karimnaaji? If so, what are the details of your machine?

Except in order to address tile 5/27/14, the epsilon needs to be set at 0.35.

avpeery avatar Oct 04 '22 21:10 avpeery

Does this solution still make the issue appear for you @karimnaaji?

Responded on the PR: https://github.com/mapbox/mapbox-gl-js/pull/12279#issuecomment-1275044877

karimnaaji avatar Oct 11 '22 17:10 karimnaaji