mapbox-gl-geocoder icon indicating copy to clipboard operation
mapbox-gl-geocoder copied to clipboard
verified publisher icon mapbox

Add option to display suggestion on setInput

Open victorneuret opened this issue 4 years ago • 2 comments

Add an optional parameter to choose whether to display the suggestion or not when using setInput

setInput used to not show the suggestions but is has been updated in https://github.com/mapbox/mapbox-gl-geocoder/pull/345 without a possibility to have the same behaviour than before. As stated by https://github.com/mapbox/mapbox-gl-geocoder/pull/345#issuecomment-804175282 it feels more like a breaking change than an improvement.

In this issue we can see the behaviour difference https://github.com/mapbox/mapbox-gl-geocoder/issues/401 .

victorneuret avatar Jul 10 '21 07:07 victorneuret

When testing my suggestions I noticed that it will need an upgrade of uglify from v2 to v3, since uglify v2 is too old to be able to handle default parameters.

If this isn't acceptable we could drop the default parameter and go back to the === undefined logic.

antony avatar Jul 23 '21 10:07 antony

My team have encountered this issue and are hoping for a fix. Happy to contribute on this PR but it's not clear what's needed. @antony can you let me know what work needs doing here and we can see about helping out; the PR seems to have stalled for a few months. Thanks

M1ke avatar Oct 27 '21 11:10 M1ke