mapbox-gl-geocoder icon indicating copy to clipboard operation
mapbox-gl-geocoder copied to clipboard

width should be left to 100%

Open mariusa opened this issue 4 years ago • 3 comments

mapbox-gl-js version: v1.11.0

browser: Chrome

Steps to Trigger Behavior

https://docs.mapbox.com/mapbox-gl-js/example/mapbox-gl-geocoder-outside-the-map/

Remove the hacks on the page (geocoder class position absolute...) and try to make the text input 100% width. This class prevents it:

@media screen and (min-width: 640px)
.mapboxgl-ctrl-geocoder {
    width: 33.3333%;
    font-size: 15px;
    line-height: 20px;
    max-width: 360px;
}

That page even has a hack to fix this:

.mapboxgl-ctrl-geocoder {
    min-width: 100%;
}

Please remove both width styles from mapboxgl-ctrl-geocoder and let us style it like any html, so it fits it's container size by default.

Expected Behavior

100% width by default on all screen sizes. Developers can add containers as they wish.

Actual Behavior

Screenshot from 2020-06-23 22-33-58

mariusa avatar Jun 23 '20 19:06 mariusa

If I understand this correctly, we would simply remove some of the style css we propose with the library to enable more customization on your use case. Would overriding these properties with https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity possible? We welcome PRs for such small improvements when it facilitates developers customizability!

karimnaaji avatar Jun 23 '20 21:06 karimnaaji

Is this an issue with mapbox-gl-js or mapbox-gl-geocoder?

@mariusa if you had a PR for the suggested change that would be great. Keeping in mind we also need reasonable defaults so just adding the control without any customisation works.

andrewharvey avatar Jun 24 '20 05:06 andrewharvey

Hi,

Is this an issue with mapbox-gl-js or mapbox-gl-geocoder?

The problematic style is in https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-geocoder/v4.5.1/mapbox-gl-geocoder.css

Would it be possible to please move this issue in https://github.com/mapbox/mapbox-gl-geocoder ?

Keeping in mind we also need reasonable defaults so just adding the control without any customisation works.

Totally agree. That's why I opened an issue instead if fixing it myself with an overwrite. The demo page also fixes this with an overwrite. Let's have better defaults!

mariusa avatar Jun 24 '20 05:06 mariusa