mapbox-gl-draw icon indicating copy to clipboard operation
mapbox-gl-draw copied to clipboard

Published 20 hours ago • verified publisher icon mapbox

Enable touch event propagation

Open Plantain opened this issue 5 years ago • 4 comments

Touch events are inexplicably prevent from propagating while mouse clicks propagate fine. Fix for #617

Requires testing across some more devices.

Plantain avatar Oct 26 '18 19:10 Plantain

Please merge this.

raysuelzer avatar Dec 13 '18 01:12 raysuelzer

Are there any updates on this PR? Will it be merged or not?

Thanks!

sergei-zelinsky avatar Jan 21 '19 11:01 sergei-zelinsky

This looks closely related to #869, with the exception that that PR moves this until later instead of preventing default altogether. I think this PR can be closed in favor of that one. cc @arindam1993

rreusser avatar Feb 26 '21 23:02 rreusser

Is there anything preventing this PR from being merged + released?

Just for the record: This bug makes using mapbox virtually impossible with Chrome devtools opened in 'touch device mode' and I fear the same is true for all devices supporting both mouse + touch. Placing and moving a point for instance works, but no draw.update events will be fired on touch interaction. Bummer. :cry:

m-vo avatar Mar 28 '21 16:03 m-vo

Hi! I'm sorry for not getting back to you sooner. We've switched to passive event listeners instead of preventDefault here, and this should be fixed in the next release https://github.com/mapbox/mapbox-gl-draw/pull/1146

stepankuzmin avatar Jan 25 '23 15:01 stepankuzmin