mapbox-gl-draw icon indicating copy to clipboard operation
mapbox-gl-draw copied to clipboard

Code not transpiled for IE11

Open sroettering opened this issue 7 years ago • 11 comments

It is important for our customer that our application works in IE11 (and others as well), however this plugin currently does not work in IE11, because IE does not support some ES features like const in for...of loops.

mapbox-gl-js version: 0.36.0 mapbox-gl-draw version: 0.17.4

Steps to Trigger Behavior

  1. Open Internet Explorer

Expected Behavior

No errors on console

Actual Behavior

console throws: 'Const must be initialized' error

Possible fix: transpile with es2015-ie babel preset

sroettering avatar Apr 28 '17 14:04 sroettering

Sven,

Thanks for opening this. Can you make a PR that implements your proposal?

Regards, Matthew

mcwhittemore avatar Apr 28 '17 15:04 mcwhittemore

I think #637 is blocking this issue since the sources get transformed by babelify and put into dist/mapbox-gl-draw.js which would work fine if the file wouldn't be empty and the 'main' entry in package.json would point to this file.

sroettering avatar May 02 '17 09:05 sroettering

We are seeing this problem as well. It would be great to get this resolved.

LarryFix avatar May 04 '17 15:05 LarryFix

I'm pretty sure this is fixed in 0.18.0. I'm not sure why the distribution was lost in 0.17.4, but it should be available now.

Following https://github.com/mapbox/mapbox-gl-draw/issues/637 for distribution confirmation.

mcwhittemore avatar May 16 '17 14:05 mcwhittemore

This https://github.com/mapbox/mapbox-gl-draw/pull/648 is missing for the fix.

sroettering avatar May 29 '17 09:05 sroettering

It is happening again. main point to index.js that is not transpilled.

chyzwar avatar Feb 26 '19 11:02 chyzwar

@andrewharvey can you please re-open this issue?

chyzwar avatar Feb 28 '19 12:02 chyzwar

Fixed in https://github.com/mapbox/mapbox-gl-draw/releases/tag/v1.2.0-beta.1

kkaefer avatar Jan 08 '20 13:01 kkaefer

Still doesn't transpile.

eusahn avatar Mar 06 '20 22:03 eusahn

For me neither. @andrewharvey can you reopen this once again?

cafca avatar Aug 18 '20 10:08 cafca

+1 I am currently experiencing this issue as of March 2021

ghost avatar Mar 30 '21 02:03 ghost