maozdemir

Results 94 comments of maozdemir

> Hi, I did it but it fails (disregard the "already exists" as I did it twice to be sure: "PS C:\Users\pemal\source\repos\GPT\privateGPT> git clone https://github.com/abetlen/llama-cpp-python fatal: destination path 'llama-cpp-python' already...

I don't know why but the README.md got environment variables part removed. Rename `example.env` file to `.env`.

And who is the owner of this server? Come on...

Why are you submitting 2.5k filrs at once? You didn't even say what this does, nıt even in commit descriptions... Edit: Ok most of them are your "datasets"/"source documents", consider...

`ImportError: TensorBoard logging requires TensorBoard version 1.15 or above` can you run `pip3 install tensorboard` or make sure that your installed version is higher than 1.15?

> `ensure_integrity` is duplicated which is not great, if we want to do the check in both scripts we should add a `util.py` module or something. Same thing for the...

The translation part feels like bloating the main script. I think it'd be much better if it was in a separate file/module.

> If this is doing external `http` requests to Google or any other server, I'm quite a bit against this (totally against if it's default on). The point of this...

> @maozdemir By default we use GoogleTranslate, and no separate server. > > I provide options for server because I'm developing it, and it can be customized by plugins -...

> > IMO the decision should be left to the end user, yet I doubt that this solution is THE solution. > > I very much agree with this, but...