mpv-dark-box icon indicating copy to clipboard operation
mpv-dark-box copied to clipboard

Not working on mpv v0.37.0 and after

Open Ashkanten opened this issue 1 year ago • 3 comments

Not working. Some API changes broke OSC scripts so they need to be updated due to newer versions of mpv (v0.37.0 and after). please fix this. i really like your script. many thanks

Ashkanten avatar Aug 06 '24 12:08 Ashkanten

Are you on Windows? If yes' this issue is dupe of #8

lasersPew avatar Sep 07 '24 04:09 lasersPew

Are you on Windows? If yes' this issue is dupe of #8

Issue is Fixed thanks to: https://github.com/0dist/oscc/issues/6#issuecomment-2387559031

Find:

utils.shared_script_property_set("osc-margins", string.format("%f,%f,%f,%f", margins.l, margins.r, margins.t, margins.b)) Replace it with:

if mp.del_property then mp.set_property_native("user-data/osc/margins", margins) else utils.shared_script_property_set("osc-margins", string.format("%f,%f,%f,%f", margins.l, margins.r, margins.t, margins.b)) end Then find:

utils.shared_script_property_set("osc-margins", nil) Replace it with:

if mp.del_property then mp.del_property("user-data/osc/margins") else utils.shared_script_property_set("osc-margins", nil) end This will ensure compatibility for older and current mpv versions.

Ashkanten avatar Oct 17 '24 21:10 Ashkanten

I already forked this repo several years ago to add Volume button, but it seems author does not open this repo all those years, so I've decided to continue maintaining

It contains fix for the issue already.

Link to repo if anyone interested: https://github.com/Mayurifag/mpv-dark-box

Mayurifag avatar Aug 05 '25 16:08 Mayurifag